add MONGOMS_SKIP_MD5_CHECK environment option #114
Merged
+95
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitriylol
force-pushed
the
mongodb-installation-option
branch
from
dd67fc8
to
a8d3bcc
Compare
AJRdev
requested changes
Dec 6, 2018
dimitriylol
force-pushed
the
mongodb-installation-option
branch
2 times, most recently
from
7ca8471
to
f2f3508
Compare
Response to the comment nodkz#114 (comment)
dimitriylol
added a commit
to dimitriylol/mongodb-memory-server
that referenced
this pull request
Dec 6, 2018
dimitriylol
force-pushed
the
mongodb-installation-option
branch
from
daedb1d
to
5cbd7cf
Compare
nodkz
approved these changes
Dec 6, 2018
There was a problem hiding this comment.
Great job! I'm ready to merge this PR.
But can you make last two small improvements:
- move
const mongoDBArchiveMd5 = await this.download(${downloadUrl}.md5);insidecheckMd5method. It clean ups a little bit the code. And if disabled checking then do not download md5 at all. - rename
checkMd5tocheckMD5for better view
@AJRdev any other additions?
AJRdev
requested changes
Dec 6, 2018
|
@nodkz Just a little change request for consistency regarding a recent PR but out of that everything seems good to me :) |
For details see nodkz#114 (comment) and nodkz comment after approving pull request
AJRdev
approved these changes
Dec 7, 2018
|
Thanks to all for amazing Pull Request! Especially regards to @dimitriylol ;) |
|
🎉 This PR is included in version 2.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
PiresHagan
added a commit
to PiresHagan/Mongo-Memorable-Server
that referenced
this pull request
Oct 3, 2023
…ptions * fix: add error handling in postinstall * feat: add MONGOMS_SKIP_MD5_CHECK for skipping md5 check * refactor: add return type in checkMd5 signature Response to the comment nodkz/mongodb-memory-server#114 (comment) * refactor: add checkMD5 parameter to the MongoBinaryDownload constructor For details see nodkz/mongodb-memory-server#114 (comment) * refactor: style changes and function renaming For details see nodkz/mongodb-memory-server#114 (comment) and nodkz comment after approving pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several changes in this pull request:
FYI: md5 sum has been updated in the MongoDB mirror, so I removed my workaround in MongoBinary-test.js. Even this pull request currently isn't required, I think it's good to have such option for the future.