cleanup http handling logic

[mwarning]

This is a first step to make the code clearer.

[mwarning]

@bluewavenet maybe you can give it a test.

[bluewavenet]

@mwarning
Sorry for the delay!
It compiles and runs fine at least on a quick test on a fas test system.
I will test all the combinations fas / binauth / basic mode tomorrow, but looks good.

[bluewavenet]

@mwarning
Works perfectly with all combinations of basic/binauth/fas :-D

[mwarning]

good to know - thanks!

[mwarning]

@bluewavenet is status page also displayed? Do you have some css or image file included?

[bluewavenet]

@mwarning
Yes, status with splash image, css (with custom tags :-p ). Works perfectly.
I rebased from master and re-compiled just to make sure.

[bluewavenet]

Wait - might be an issue..... couple more tests....

[bluewavenet]

@mwarning
Actually no it is not working with status.html in basic and/or binauth mode, but does with fas enabled.
On clicking "back" on the browser then clicking "Continue" again, NDS returns:
http://10.168.1.1:2050/nodogsplash_auth/?tok=acfa9be5&redir=http%3A%2F%....... etc

Should be:
http://10.168.1.1:2050/status.html?tok=acfa9be5&redir=http%3A%2F%.... etc

[bluewavenet]

@mwarning
I mistyped my last comment so edited it.

[mwarning]

ok, looks like I have some fixing to do.

[lynxis]

@mwarning do you like to redo this PR again onto the current master? It would be great.

[mwarning]

I will do it this week.

[mwarning]

rebase is done. But I need to revisit/test the logic to check if this does not break anything.