New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Application.addMiddleware #143

Closed

artem-burlakov-ext-orion wants to merge 1 commit into nodosjs:master from artem-burlakov-ext-orion:fix_addmiddlewares_branch

artem-burlakov-ext-orion commented Mar 8, 2021 •

edited

before:

 addMiddleware(filepath) {
    const filename = path.basename(filepath);
    const middlewareName = filename.replace(path.extname(filename), '');
    log('addMiddleware', middlewareName, filepath);
    // FIXME: check uniqueness
    this.middlewares[middlewareName] = filepath;
  }

after:

addMiddleware(filepath) {
    const filename = path.basename(filepath);
    const middlewareName = filename.replace(path.extname(filename), '');
    log('addMiddleware', middlewareName, filepath);
    if (has(this.middlewares, middlewareName)) {
      throw new Error(`Middleware ${middlewareName} already exists`);
    }
    this.middlewares[middlewareName] = filepath;
  }


          fix Application.addMiddleware

acebb22

artem-burlakov-ext-orion closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment