FEI-11316: Save original error for NetworkError #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for the error in the tests: ``` Error: Buffer.write(string, encoding, offset[, length]) is no longer supported ```
|
Ну ладно. Теперь я сражусь с мамонтом Node.js |
|
lgtm, node.js < 0.10 нужно дропнуть из поддержки |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Посмотрел соседние пулл-реквесты, а там на русском пишут. Вот и я умею. Вот и буду.
Зачем?
Много раз в Hermione/Gemini/TestPalmAPI и прочих пакетах мы страдаем из-за нехватки знаний об ошибке. Например, Sandbox отдаёт информацию об ошибке в
StatusMessage. В TestPalm в случае ошибки отдают больше деталей об ошибке в теле ответа. Так давайте будет пробрасывать всё то :)Что сделано?
formidable, иначе тесты ругаются на Node.js 8+. Мол,Buffer.writeотмер.302. Но правильно это или нет, из описания теста я не понял.NetworkErrorвendобработчик ответа.