Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue migration #30

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Vue migration #30

wants to merge 17 commits into from

Conversation

jannessm
Copy link

@jannessm jannessm commented Aug 4, 2023

Hi,
I just refactored your project to use vuejs. Now the code should be more cleaner and easier to extend by contribution.

Also I added buttons to add and remove animated lower thirds (up to 10)

@midnight-studios
Copy link

midnight-studios commented Oct 23, 2023

Hey, this update is amazing!

Can you check if this and this is correct?

@midnight-studios
Copy link

Enable/Disable has no effect, it renders the color regardless when it should be none:

        color1() { return this.background ? this.backgroundColor1.value : 'none'; },
        color2() { return this.background ? this.backgroundColor2.value : 'none'; },

image

@midnight-studios
Copy link

midnight-studios commented Oct 23, 2023

Can you please check this, this and this

Before:

        color1() { return this.background ? this.backgroundColor1.value : 'none'; },
        color2() { return this.background ? this.backgroundColor2.value : 'none'; },
        color3() { return this.border ? this.bordersColor1.value : 'none'; },
        color4() { return this.border ? this.bordersColor2.value : 'none'; },

After:

        color1() { return this.background.value ? this.backgroundColor1.value : 'none'; },
        color2() { return this.background.value ? this.backgroundColor2.value : 'none'; },
        color3() { return this.borders.value ? this.bordersColor1.value : 'none'; },
        color4() { return this.borders.value ? this.bordersColor2.value : 'none'; },

@jannessm
Copy link
Author

Thank you for your review. I will have a look at it!

@jannessm
Copy link
Author

your issues should be fixed now.

@jannessm
Copy link
Author

jannessm commented Jan 7, 2024

I hopefully fixed the slots issues and the 'alt-1-'s that I haven't replaced. There was also another bug in the image selector. Hopefully everything is working now! Sorry for such a buggy pull request.

@DavidP-B
Copy link
Collaborator

DavidP-B commented Feb 7, 2024

Hi @jannessm , first of all thank you very much for this incredible refactor!! I want to try it but with previous PR that I've accepted, now have been appear some conflicts. Can you resolve it please? I will try to review your PR and accept it asap.

@jannessm
Copy link
Author

I added now the new style. other PRs I havent found except the readme update which should be no conflict when merging. Hope that everything works fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants