Fix RTREUSEWHERE in CREATEQUERY

[lummax]

First up: tremendous work!

While testing the WSP implementation with a Windows 8.1 I noticed an error in
the handling of the RTREUSEWHERE restriction. The code correctly identified
the case and called rtreusewhere_to_string(), but neither the share nor the
where_id where passed back, resulting in an error in run_new_query_send() as
the share was not set.

I believe with this, the find_query_info() in run_new_query_send() is
redundant, but I'm not quite sure.

I also added some more debug output to hunt that down.

[noelpower]

Hi Lucas,
Sorry for the delay in getting back to you, just busy with something at the moment and hope to get some free time next week, I have in the mean time some questions.
Are you able to reproduce the bug? If so can you provide level 10 samba logs and a network trace for the attempt that fails ? I would really love to understand what happens there. I don't doubt that this happens, I have fixed some similar issue before, either I broke this again or this is a new variation (and I no longer recall how the previous variation manifested itself :-))

[lummax]

See log_and_capture.zip for log.wspd and network traces. The pre_patches* version is without commit a02623f but with added debug logging. The post_patches* is the fixed version.

I have rebased the WSP-WIP branch and my patches on 4.6.rc2 but that should not make a difference.

This is the interesting section with the new debug message run_new_query_send: No share passed in the RestrictionSet.

[2017/02/24 15:35:58.756276,  3, pid=7422, effective(0, 0), real(0, 0)] ../source3/rpc_server/wsp/wsp_gss.c:1936(handle_wsp_send)
  handle_wsp_send: received CPMCREATEQUERY message from handle 1
[2017/02/24 15:35:58.756303,  5, pid=7422, effective(0, 0), real(0, 0)] ../source3/rpc_server/wsp/wsp_gss.c:102(get_connected_client_entry)
  get_connected_client_entry: compare 0x1 with 0x2
[2017/02/24 15:35:58.756319,  5, pid=7422, effective(0, 0), real(0, 0)] ../source3/rpc_server/wsp/wsp_gss.c:102(get_connected_client_entry)
  get_connected_client_entry: compare 0x1 with 0x1
[2017/02/24 15:35:58.756495, 10, pid=7422, effective(0, 0), real(0, 0)] ../source3/rpc_server/wsp/wsp_sparql_conv.c:1555(rtreusewhere_to_string)
  rtreusewhere_to_string: SHARE reusewhereid 2
[2017/02/24 15:35:58.756515,  3, pid=7422, effective(0, 0), real(0, 0)] ../source3/rpc_server/wsp/wsp_sparql_conv.c:1577(rtreusewhere_to_string)
  rtreusewhere_to_string: detected a where id RTREUSEWHERE id=2 result = (((false != true)) && tracker:uri-is-descendant ('file:///var/shares/test-share', nie:url (?u)))
[2017/02/24 15:35:58.756537,  0, pid=7422, effective(0, 0), real(0, 0)] ../source3/rpc_server/wsp/wsp_srv_tracker_abs_if.c:379(run_new_query_send)
  run_new_query_send: No share passed in the RestrictionSet
[2017/02/24 15:35:58.756557, 10, pid=7422, effective(0, 0), real(0, 0), class=tevent] ../source3/lib/tevent_glib_glue.c:617(tevent_glib_process)
  tevent_glib_process: tevent_glib_process: num_ready: 0
[2017/02/24 15:35:58.756575, 10, pid=7422, effective(0, 0), real(0, 0), class=tevent] ../source3/lib/tevent_glib_glue.c:429(get_glib_fds_and_timeout)
  get_glib_fds_and_timeout: get_glib_fds_and_timeout: num fds: 1, timeout: -1 ms
[2017/02/24 15:35:58.756593,  0, pid=7422, effective(0, 0), real(0, 0)] ../source3/rpc_server/wsp/wsp_gss.c:1977(handle_wsp_done)
  handle_wsp_done: detected some async processing error NT_STATUS_INVALID_PARAMETER 0xc000000d for request 0x559ff9c76790

Thank you for taking the time to look at this :).

[noelpower]

Finally got a chance to look at the logs/trace. Yep, this is badly broken, this should (and used) to work, building the query using the whereid is a key requirement (I'd say you see more queries using a whereid than without on later windows clients) It looks I removed code this by accident at some point (hard to see because I rewrite the branch history to keep the number of patches for upstreaming manageable) This is the missing part I think your patch is neater so if you care to resubmit the patches with your signoff (please see https://wiki.samba.org/index.php/CodeReview#commit_message_tags) understanding that this is necessary for me to upstream this eventually. I don't want to be chasing sign-offs etc. later on so please read the wiki section especially paying attention to the copyright policy etc:-)

[lummax]

Copyright mail got send, patches are rebased to WSP-WIP and signed of. I deleted the code added in 0a9d82f as it's redundant now.

[noelpower]

Hi Lukas,
those changes look fine to me thanks! could you also incorporate removal of these lines in the commit, I think you are correct they are no longer necessary.

[noelpower]

Hi Lukas, sorry for being a pain but could you possibly squash this commit with the "fix share-lookup on RTREUSEWHERE" one ? I think they really should be part of the one change

[lummax]

@noelpower no worries :)

Done!