Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks.due_date and tasks.priority should not be strings #12

Closed
stejskalleos opened this issue May 9, 2022 · 1 comment
Closed

tasks.due_date and tasks.priority should not be strings #12

stejskalleos opened this issue May 9, 2022 · 1 comment

Comments

@stejskalleos
Copy link
Collaborator

In schema.rb, tasks.due_date and tasks.priority are both strings, but I think that due_date should be datetime and priority should be integer.

Models should have some validations:

  • due_date should be validated that it can be only in the future
  • priority should be limited to some selection, lets say from 1 to 3

UI should be updated accordingly to the changes

@nofaralfasi
Copy link
Owner

Created this PR solving this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants