Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: move using directive to top #68

Merged
merged 3 commits into from
Feb 10, 2022
Merged

style: move using directive to top #68

merged 3 commits into from
Feb 10, 2022

Conversation

nogic1008
Copy link
Owner

@nogic1008 nogic1008 commented Feb 10, 2022

  • declare to use file-scoped namespace on .editorconfig (to dismiss IDE0160)
  • move using directive to top (to fix IDE0065)
  • remove unused using directive (to fix CS8019)

@nogic1008 nogic1008 added the invalid ⚠️ This doesn't seem right label Feb 10, 2022
@nogic1008 nogic1008 added this to the v1.1.2 milestone Feb 10, 2022
@nogic1008 nogic1008 self-assigned this Feb 10, 2022
@commit-lint
Copy link

commit-lint bot commented Feb 10, 2022

Styles

  • use file-scoped namespace (fdf3a4e)
  • move using directive to top (42add8d)
  • remove unused using (46a6897)

Contributors

nogic1008

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #68 (46a6897) into main (f97dc72) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           63        63           
  Branches         7         7           
=========================================
  Hits            63        63           
Flag Coverage Δ
Linux 100.00% <ø> (ø)
Windows 100.00% <ø> (ø)
macOS 100.00% <ø> (ø)
net6.0 100.00% <ø> (ø)
netcoreapp3.1 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Nogic.WritableOptions/JsonWritableOptions.cs 100.00% <ø> (ø)
...ogic.WritableOptions/ServiceCollectionExtension.cs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f97dc72...46a6897. Read the comment docs.

@nogic1008 nogic1008 merged commit f1794e1 into main Feb 10, 2022
@nogic1008 nogic1008 deleted the chore/using-directive branch February 10, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid ⚠️ This doesn't seem right refactor ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant