Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use LoggerMessage pattern #78

Merged
merged 3 commits into from
Feb 17, 2022
Merged

refactor: use LoggerMessage pattern #78

merged 3 commits into from
Feb 17, 2022

Conversation

nogic1008
Copy link
Owner

fix CA1727 and CA1848

@commit-lint
Copy link

commit-lint bot commented Feb 17, 2022

Code Refactoring

  • use PascalCase for named placeholders (9508319)
  • use LoggerMessageAttribute to log AppOption (184d37a)
  • use LoggerMessage.Define (9ee7114)

Contributors

nogic1008

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #78 (9ee7114) into main (49aa44e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           61        61           
  Branches         7         7           
=========================================
  Hits            61        61           
Flag Coverage Δ
Linux 100.00% <ø> (ø)
Windows 100.00% <ø> (ø)
macOS 100.00% <ø> (ø)
net6.0 100.00% <ø> (ø)
netcoreapp3.1 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49aa44e...9ee7114. Read the comment docs.

@nogic1008 nogic1008 added development 🚀 Area development (testing, deploy...) refactor ✨ labels Feb 17, 2022
@nogic1008 nogic1008 self-assigned this Feb 17, 2022
@nogic1008 nogic1008 added this to the v1.1.2 milestone Feb 17, 2022
@nogic1008 nogic1008 merged commit ab6d809 into main Feb 17, 2022
@nogic1008 nogic1008 deleted the refactor/logging branch February 17, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development 🚀 Area development (testing, deploy...) refactor ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant