Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other SecureRandom methods #1

Open
sdodson opened this issue Nov 17, 2014 · 5 comments
Open

Support other SecureRandom methods #1

sdodson opened this issue Nov 17, 2014 · 5 comments

Comments

@sdodson
Copy link
Collaborator

sdodson commented Nov 17, 2014

It'd be nice if this module supported the other methods for SecureRandom. I'm working on a patch for this as I need to generate passwords that are constrained to base64 but I wanted to get an issue in to get your thoughts. My proposal is to add a third argument which specifies the method, if that argument is null then it will fall back to the current logic. If it's non null it will use the argument to specify which method to use.

http://www.ruby-doc.org/stdlib-1.9.3/libdoc/securerandom/rdoc/SecureRandom.html

@nogweii
Copy link
Owner

nogweii commented Nov 17, 2014

Sounds like a good plan!

And in other news, I haven't touched this in a long while. Would you consider taking over maintenance?

@sdodson sdodson mentioned this issue Nov 18, 2014
@sdodson
Copy link
Collaborator Author

sdodson commented Nov 18, 2014

Other than this change I didn't see any other changes that came to mind but I'm happy to take over maintenance. I'll be using this module in our OpenShift module anyway so I'm sure it'll remain an area of interest for me.

@sdodson
Copy link
Collaborator Author

sdodson commented Nov 19, 2014

I've gone ahead and created travis-ci setup for the module and pushed to the forge using my fork. Anything else we should do regarding transfer of maintenance?

@nogweii
Copy link
Owner

nogweii commented Nov 19, 2014

I guess the last part would be to give you commit bit on this repo, or migrate it to be underneath your own profile.

Do you prefer one or the other?

@sdodson sdodson closed this as completed Nov 19, 2014
@sdodson sdodson reopened this Nov 19, 2014
@sdodson
Copy link
Collaborator Author

sdodson commented Nov 19, 2014

I don't have a preference one way or the other, though I've already pretty much got things setup under my profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants