-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support other SecureRandom methods #1
Comments
Sounds like a good plan! And in other news, I haven't touched this in a long while. Would you consider taking over maintenance? |
Other than this change I didn't see any other changes that came to mind but I'm happy to take over maintenance. I'll be using this module in our OpenShift module anyway so I'm sure it'll remain an area of interest for me. |
I've gone ahead and created travis-ci setup for the module and pushed to the forge using my fork. Anything else we should do regarding transfer of maintenance? |
I guess the last part would be to give you commit bit on this repo, or migrate it to be underneath your own profile. Do you prefer one or the other? |
I don't have a preference one way or the other, though I've already pretty much got things setup under my profile. |
It'd be nice if this module supported the other methods for SecureRandom. I'm working on a patch for this as I need to generate passwords that are constrained to base64 but I wanted to get an issue in to get your thoughts. My proposal is to add a third argument which specifies the method, if that argument is null then it will fall back to the current logic. If it's non null it will use the argument to specify which method to use.
http://www.ruby-doc.org/stdlib-1.9.3/libdoc/securerandom/rdoc/SecureRandom.html
The text was updated successfully, but these errors were encountered: