Base64 #2
Merged
Base64 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some passwords may not accept the character set generated by the default method so we'll provide access to all the methods provided by SecureRandom. Obviously some of these are poor choices for passwords, but we'll provide the flexibility to use all of them.
|
Fixes #1 |
|
:-) and of course my specs don't run on ruby 1.8.7. I'll fix that. |
nogweii
pushed a commit
that referenced
this pull request
Nov 19, 2014
Base64 or URL encoded secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying the SecureRandom method to call encase users need character sets constrained to base64 or url encoded.