Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the popover aware of screen edges #1

Closed
michaelryancaputo opened this issue Feb 21, 2014 · 10 comments
Closed

Make the popover aware of screen edges #1

michaelryancaputo opened this issue Feb 21, 2014 · 10 comments

Comments

@michaelryancaputo
Copy link

Is it possible to make the popover aware if it will be going outside of the browser viewport and to compensate?

@nohros
Copy link
Owner

nohros commented Feb 22, 2014

I did not understand what you mean? Can you explain it with more detail?

@michaelryancaputo
Copy link
Author

If a popover is too close to the screen edge, instead of expanding outside the viewport, causing the screen to expand, have it adjust to not expand that far.—
Sent from Mailbox for iPhone

On Fri, Feb 21, 2014 at 7:23 PM, nohros notifications@github.com wrote:

I did not understand what you mean? Can you explain it with more detail?

Reply to this email directly or view it on GitHub:
#1 (comment)

@michaelryancaputo
Copy link
Author

Here's an example of what I mean.
screen shot 2014-02-25 at 12 49 32 pm

@nohros
Copy link
Owner

nohros commented Feb 25, 2014

Ok, in that case the edge of the popover should be the edge of the viewport and the popover should be redimensioned, or the popover should be moved to the left?

@michaelryancaputo
Copy link
Author

That would be great—
Sent from Mailbox for iPhone

On Tue, Feb 25, 2014 at 6:49 PM, nohros notifications@github.com wrote:

Ok, in that case the edge of the popover should be the edge of the viewport?

Reply to this email directly or view it on GitHub:
#1 (comment)

@nohros
Copy link
Owner

nohros commented Feb 26, 2014

The popover should be re-dimensioned or moved to the left?

@michaelryancaputo
Copy link
Author

for my purpose i'd just say let it move to the left

@httpete
Copy link

httpete commented Dec 1, 2014

Edge detection is needed. It should detect if it is off the viewport, and pop a different direction.

@httpete
Copy link

httpete commented Jan 12, 2015

@nohros
Copy link
Owner

nohros commented Aug 6, 2015

Fixed by PR #94

@nohros nohros closed this as completed Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants