Skip to content

Commit

Permalink
Remove Quick View and related facilities
Browse files Browse the repository at this point in the history
The Quick View was intended to provide a nice overview over datasets.

Implemented for the ODHActivityPoi datasets, it turned out that the Quick View it is not needed
at the moment (see issue #552 on GitHub).

Therefor, this commit removes all of the Quick View related code and configs and moves / renames
the shared stuff that is still used to other locations.
  • Loading branch information
gappc committed Apr 14, 2024
1 parent 5655965 commit b33986f
Show file tree
Hide file tree
Showing 81 changed files with 75 additions and 1,566 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ For more information on how to make new files REUSE compliant check the project

- **Christian Gapp** - _Initial work_ - [gappc](https://github.com/gappc)
- **AboutBits** - _Initial work_ - [AboutBits](https://github.com/aboutbits)
- **FlashBeing** - Guideline and _Quick View_ [FlashBeing](https://flashbeing.com/)
- **FlashBeing** - _Lots of contributions_ [FlashBeing](https://flashbeing.com/)
- **NOI Support Team** - _Configurations and tests_

### Acknowledgements
Expand Down
2 changes: 1 addition & 1 deletion databrowser/guideline.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const MyLibrary = defineAsyncComponent(() =>

### Platform assumptions

1. The DetailView and QuickView are designed to be generated through configuration files, differentiated according to the type of dataset. These files are located in the path /src/config/DATASET_NAME/DATASET_NAME.VIEW_TYPE.ts. For example, in /src/config/odhActivityPoi/odhActivityPoi.quickView.ts, you can see the configuration of the QuickView for points of interest.
1. The DetailView and EditView are designed to be generated through configuration files, differentiated according to the type of dataset. These files are located in the path /src/config/DATASET_NAME/DATASET_NAME.VIEW_TYPE.ts. For example, in /src/config/odhActivityPoi/odhActivityPoi.detailView.ts, you can see the configuration of the DetailView for points of interest.
2. If the views define their respective components from the configuration file, they must use the ComponentRender component. To include the components with the ComponentRender component, they must be defined in /src/components/registerForComponentRender.js, and then the related components must be placed in the /src/components/ folder, using the following extension: "forRender". Eg, a component called Table that can ben rendered using the ComponentRender component, must be called Table.forRender.vue. Plus, all components built to be rendered with the ComponentRender, must respect the following predefined structure details:

```
Expand Down
93 changes: 0 additions & 93 deletions databrowser/src/components/quickview/QuickViewCardOverview.vue

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

100 changes: 0 additions & 100 deletions databrowser/src/components/quickview/QuickViewCardOverviewGallery.vue

This file was deleted.

13 changes: 0 additions & 13 deletions databrowser/src/components/quickview/QuickViewCommonTypes.ts

This file was deleted.

0 comments on commit b33986f

Please sign in to comment.