-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
authentication: Update calls to use the new client id/secret
- Loading branch information
Peter Moser
committed
Jun 11, 2020
1 parent
2218094
commit b6100e9
Showing
1 changed file
with
25 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b6100e9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Piiit would it be possible to open issues for every change instead of committing code directly on master, in order to keep track of changes you make? Thanks!
b6100e9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefanodavid You mean create a PR for the changes?
b6100e9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Piiit I try to be very precise, open issues even for small changes in order to be tracked by everyone and keeps things ordered. If you commit some change directly into master branch, everything you do is almost unknown to me. In this particular case I realised that you changed something directly on master branch only after half an hour of trying to understand why on the fancy earth I had completely different calls in the same file in different branches.
b6100e9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefanodavid It is good that you are precise, but this is a shared project, so in the future it is even possible that we have several authors, and some small bugfixes must be done fast and direct, otherwise I fear that we do not have the time to discuss every little bit. For bigger changes, or discussions you are absolutely right, that we should not commit directly to the master branch.
This was a PR review, where some small things were missing, so I fixed them directly and moved on...
Shared code ownership is a best practice in open source projects, so you need to check master from time to time and sync it with your working branch... if you need help with that I can show you how it works.
We will prepare additional documentation about these workflows, because several people complained about changing branches and merge conflicts. So, we are preparing workflow images etc.... currently to better understand how things work