Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Work whether mounted at the root context or not #127

Merged
merged 2 commits into from Nov 12, 2012

Conversation

Projects
None yet
2 participants
Contributor

jcrossley3 commented Sep 16, 2012

When a noir newbie deploys his first app to a context path on a java app server, absolute paths to resources won't work. This change should make for a compelling first experience whether the app is mounted at the root or not.

jcrossley3 added some commits Jan 28, 2012

@jcrossley3 jcrossley3 Using a relative path to a resource
Using a relative path to an image nables the image to be
successfully fetched by the browser when served from the
classpath while the app is mounted at a non-root context.
f4edc1f
@jcrossley3 jcrossley3 Remove all assumptions about host, port, and context path.
And use html5 to agree with the newnew template
a138f1b

@Raynes Raynes added a commit that referenced this pull request Nov 12, 2012

@Raynes Raynes Merge pull request #127 from jcrossley3/better-experience
Work whether mounted at the root context or not
7959c8d

@Raynes Raynes merged commit 7959c8d into noir-clojure:master Nov 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment