Add --include-path flag (#155) #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksg97031
force-pushed
the
include-path-option
branch
from
7d6b306
to
5e284ab
Compare
- Add new properties and structs to the `Endpoint` model - Add new flag options to the `noir` command line tool for various functionalities - Add unit tests for the `Endpoint` model initialization and details detection - Update the logic in the output builder to include file paths in the printed output if specified Signed-off-by: ksg97031 <ksg97031@gmail.com>
- Refactored multiple analyzer files to include the `Details` object for storing path and line number information Signed-off-by: ksg97031 <ksg97031@gmail.com>
ksg97031
force-pushed
the
include-path-option
branch
from
5e284ab
to
4221246
Compare
hahwul
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the feedback provided at #192 (comment)
I have incorporated your suggestions and made some adjustments:
Renamed the
Pathstruct toPathInfo.The Path struct had already been declared.
Changed the
--include-file-pathflag to--include-path.I considered using --with-path, but it resembled the --with-headers flag and might cause confusion.
Replaced the use of the
pathsvariable withcode_pathsin the code.Using
pathsled to code likepaths[0].path, which seemed a bit awkward. Therefore, I opted forcode_pathsas the variable name instead.In the process of refactoring, several analyzer files now include the
Detailsobject for storing path and line number information. However, in a few cases where the line number couldn't be detected, only path information is stored.I welcome any additional feedback!