Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Add a "dry-run" release check #241

Closed
1 task
TomAFrench opened this issue Apr 28, 2023 · 1 comment
Closed
1 task

Add a "dry-run" release check #241

TomAFrench opened this issue Apr 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

Problem

The 0.10.0 release could not be published due to an issue which was only apparent after the release was made.

#240

Proposed solution

To avoid this we can modify the publish.yml workflow to accept a "dry-run" argument which would use cargo publish's --dry-run flag (https://doc.rust-lang.org/cargo/commands/cargo-publish.html#publish-options)

This could be integrated into the release PR's CI, ensuring that it can only be merged if the release can be published.

Alternatives considered

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
@TomAFrench TomAFrench added the enhancement New feature or request label Apr 28, 2023
@TomAFrench
Copy link
Member Author

Closing as Cargo doesn't support this for workspaces

@TomAFrench TomAFrench closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant