Skip to content

Commit

Permalink
fix: Update noir-gates-diff commit to use master reference report (#4891
Browse files Browse the repository at this point in the history
)

# Description

## Problem\*

Further context can be found in
#4878

## Summary\*

This PR updates the commit to reference
vezenovm/noir-gates-diff#2 which actually checks
the report on master. We need the preceding PR in order to fix the
reference report to use the actual package names in `execution_success`.

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
  • Loading branch information
vezenovm committed Apr 23, 2024
1 parent 50bc325 commit 4a3ffb7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/gates_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
- name: Compare gates reports
id: gates_diff
uses: vezenovm/noir-gates-diff@45e9c9a21deb236fa7f38138b42b33ddaf7c0985
uses: vezenovm/noir-gates-diff@acf12797860f237117e15c0d6e08d64253af52b6
with:
report: gates_report.json
summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%)
Expand Down

0 comments on commit 4a3ffb7

Please sign in to comment.