Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): goto definition of trait #3725

Closed
Tracked by #1574
kobyhallx opened this issue Dec 8, 2023 · 0 comments
Closed
Tracked by #1574

feat(lsp): goto definition of trait #3725

kobyhallx opened this issue Dec 8, 2023 · 0 comments
Assignees

Comments

@kobyhallx
Copy link
Contributor

kobyhallx commented Dec 8, 2023

Considering snippet

trait Fieldable {
    fn to_field(self) -> Field;
}

impl Fieldable for u32 {
    fn to_field(self) -> Field {
        let res = self as Field;
        res * 3    
    }
}

fn main(x: u32) {
    assert(x.to_field() == 15);
}

User should be able to navigate to definition of Fieldable when on that symbol of line impl Fieldable for u32 { which should result in navigation to Fieldable symbol of trait Fieldable {.

@kobyhallx kobyhallx changed the title feat(lsp): goto idefition of trait feat(lsp): goto definition of trait Jan 4, 2024
@kobyhallx kobyhallx self-assigned this Jan 4, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 4, 2024
# Description

## Problem\*

Resolves 
feat(lsp): goto definition of trait #3725

## Summary\*

Allows to go to Trait definition from Trait Implementation.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant