Brilliw COW optimization regression #4332
Labels
bug
Something isn't working
Comments
This was referenced Feb 12, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 12, 2024
…egression test (#4333) # Description ## Problem\* Resolves: #4332 ## Summary\* ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Mar 11, 2024
# Description ## Problem\* Resolves #3795 ## Summary\* This is an older version of #4210 which undoes the change in d331ee2 due to a regression #4332. This PR is not yet confirmed to work since I do not have a test case for it! @sirasistant, do you mind seeing if this fixes the regression issue? ## Additional Context ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Aim
After #4210 the cow optimization seems to not be in effect in a critical codepath in aztec-packages protocol circuits
Expected Behavior
Should run
Bug
Tries to copy on all operations so execution never ends
To Reproduce
Project Impact
None
Impact Context
No response
Workaround
None
Workaround Description
No response
Additional Context
No response
Installation Method
None
Nargo Version
No response
NoirJS Version
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: