Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brillig's modulo_instruction uses 254-bit integer multiplication #4543

Closed
fcarreiro opened this issue Mar 13, 2024 · 2 comments
Closed

Brillig's modulo_instruction uses 254-bit integer multiplication #4543

fcarreiro opened this issue Mar 13, 2024 · 2 comments
Assignees
@sirasistant
Labels
bug Something isn't working

Comments

@fcarreiro
Copy link

Aim

Transpile to AVM bytecode

Expected Behavior

Should avoid using u254 integer ops, use Field instead or some other trick

Bug

modulo_instruction uses 254-bit integer multiplication to implement to_radix. However, that will not be supported in the AVM. Discussed with @sirasistant.

To Reproduce

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Installation Method

None

Nargo Version

No response

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@fcarreiro fcarreiro added the bug Something isn't working label Mar 13, 2024
@sirasistant sirasistant self-assigned this Mar 13, 2024
@fcarreiro
Copy link
Author

For the record, SUB is also used on 254 int

@sirasistant sirasistant mentioned this issue Mar 14, 2024
Merged
sirasistant added a commit to AztecProtocol/aztec-packages that referenced this issue Mar 14, 2024
@sirasistant
feat: New brillig field operations and refactor of binary operations (#…
eb69504 
…5208)

Fixes noir-lang/noir#4544 and
noir-lang/noir#4543
AztecBot added a commit that referenced this issue Mar 14, 2024
@AztecBot
feat: New brillig field operations and refactor of binary operations (A…
8c92772 
…ztecProtocol/aztec-packages#5208)

Fixes #4544 and
#4543
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Mar 15, 2024
@sirasistant @AztecBot
feat: New brillig field operations and refactor of binary operations …
c17b4bb 
…(#5208)

Fixes noir-lang/noir#4544 and
noir-lang/noir#4543
@sirasistant
Copy link
Contributor

fixed in AztecProtocol/aztec-packages#5208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirasistant sirasistant

Labels
bug Something isn't working
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fcarreiro @sirasistant