Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comptime globals #4916

Closed
Tracked by #4594
jfecher opened this issue Apr 24, 2024 · 0 comments · Fixed by #4918
Closed
Tracked by #4594

comptime globals #4916

jfecher opened this issue Apr 24, 2024 · 0 comments · Fixed by #4918
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Apr 24, 2024

Problem

We should be able to define comptime globals

Happy Case

comptime global FOO = bar();

fn main() {
    assert_constant(FOO); // should pass regardless of the definition of `bar`
}

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@jfecher jfecher added the enhancement New feature or request label Apr 24, 2024
This was referenced Apr 24, 2024
Open
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 29, 2024
@jfecher @TomAFrench
feat(experimental): comptime globals (#4918)
8a3c7f1 
# Description

## Problem\*

Resolves #4916 

## Summary\*

Implements immutable `comptime` globals.

I've made a separate issue for mutable comptime globals since those
would require allowing a `mut` modifier when parsing globals in general.

## Additional Context

The scopes of the interpreter were already set up for globals to work.
The main main part that was needed here was evaluating comptime-known
identifiers during the scan pass. Without this monomorphization would
just use the original rhs of each global.

## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [x] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(experimental): comptime globals noir-lang/noir
1 participant
@jfecher