Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variable argument count for attributes #5476

Closed
Tracked by #4594
jfecher opened this issue Jul 10, 2024 · 0 comments · Fixed by #5494
Closed
Tracked by #4594

Support variable argument count for attributes #5476

jfecher opened this issue Jul 10, 2024 · 0 comments · Fixed by #5494
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Jul 10, 2024

Problem

Annotations should be able to accept a variable amount of arguments to replicate macros like derive in Rust.

Happy Case

We support passing any number of arguments to annotations.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the enhancement New feature or request label Jul 10, 2024
@jfecher jfecher changed the title Support variable argument count for annotations Support variable argument count for attributes Jul 11, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 11, 2024
# Description

## Problem\*

Resolves #5473
Resolves #5476

## Summary\*

Allows arguments to attribute functions.
- These arguments are all quoted by default. This is to replicate
something like Rust's `#[derive(Foo, Bar)]` where `Foo` and `Bar` are
meant to be traits rather than values in scope.
- Varargs is also possible if the attribute accepts a slice of Quoted
values rather than individual Quoted arguments.

## Additional Context

## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [x] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant