Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ssa refactor): Add basic instruction simplification #1329

Merged
merged 4 commits into from May 16, 2023
Merged

chore(ssa refactor): Add basic instruction simplification #1329

merged 4 commits into from May 16, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented May 9, 2023

Related issue(s)

Resolves #

Description

Summary of changes

Adds an Instruction::simplify method to see if an instruction should be simplified by being replaced with a known value. The method does not recurse* so it cannot simplify cases like 2 * x / 2.

  • It actually does recurse in one case: it checks for !!x to simplify it to x. This might be moved to wherever we check for the more complex simplifications down the line, or perhaps we'll add those simplifications in the same place as well.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@kevaundray kevaundray added this pull request to the merge queue May 16, 2023
@kevaundray kevaundray removed this pull request from the merge queue due to a manual request May 16, 2023
@kevaundray kevaundray added this pull request to the merge queue May 16, 2023
Merged via the queue into master with commit 63d84a3 May 16, 2023
9 checks passed
@kevaundray kevaundray deleted the jf/ssa-simplify branch May 16, 2023 12:06
TomAFrench added a commit that referenced this pull request May 17, 2023
@TomAFrench
Merge branch 'master' into jf/fix-1110
df0d879 
* master: (66 commits)
  feat(nargo)!: retire print-acir in favour of flag (#1328)
  chore(ssa): enable cse for assert (#1350)
  chore(ssa refactor): Add basic instruction simplification (#1329)
  chore(noir): Release 0.6.0 (#1279)
  feat: enable to_radix for any field element (#1343)
  chore(ssa refactor): Simplify inlining pass and fix inlining failure (#1337)
  chore!: Update to acvm 0.11.0 (#1322)
  feat: Add ECDSA secp256k1 builtin test (#1294)
  chore: add support for encoding/decoding inputs from JSON (#1325)
  feat: Issue an error when attempting to use a `return` expression (#1330)
  chore(ssa refactor): Fix inlining bug (#1335)
  fix: to-bits and to-radix for > 128 bits (#1312)
  chore(parser): Parser error optimisation (#1292)
  chore(ssa refactor): Implement function inlining (#1293)
  chore: fix installation link in readme (#1326)
  chore: fix installation link in readme (#1326)
  feat(stdlib): Add keccak (#1249)
  fix: Parsing nested generics (#1319)
  chore(ssa refactor): Document some SSA-gen functions (#1321)
  fix: Assigning to tuple fields (#1318)
  ...
TomAFrench added a commit that referenced this pull request May 18, 2023
@TomAFrench
Merge branch 'master' into mv/opcode_supported
d1ec8d2 
* master:
  fix: Fix modulo operator for comptime values (#1361)
  chore: clarify that `verify_signature` takes a hashed message (#1365)
  feat: pass in closure to `Driver` to signal backend opcode support (#1349)
  feat(nargo)!: retire print-acir in favour of flag (#1328)
  chore(ssa): enable cse for assert (#1350)
  chore(ssa refactor): Add basic instruction simplification (#1329)
  chore(noir): Release 0.6.0 (#1279)
TomAFrench added a commit that referenced this pull request May 18, 2023
@TomAFrench
Merge branch 'master' into phated/ref-string
2ac6352 
* master:
  fix: Fix modulo operator for comptime values (#1361)
  chore: clarify that `verify_signature` takes a hashed message (#1365)
  feat: pass in closure to `Driver` to signal backend opcode support (#1349)
  feat(nargo)!: retire print-acir in favour of flag (#1328)
  chore(ssa): enable cse for assert (#1350)
  chore(ssa refactor): Add basic instruction simplification (#1329)
  chore(noir): Release 0.6.0 (#1279)
TomAFrench added a commit that referenced this pull request May 18, 2023
@TomAFrench
Merge branch 'master' into phated/acvm-0.12.0
fc9df35 
* master:
  fix: Fix modulo operator for comptime values (#1361)
  chore: clarify that `verify_signature` takes a hashed message (#1365)
  feat: pass in closure to `Driver` to signal backend opcode support (#1349)
  feat(nargo)!: retire print-acir in favour of flag (#1328)
  chore(ssa): enable cse for assert (#1350)
  chore(ssa refactor): Add basic instruction simplification (#1329)
  chore(noir): Release 0.6.0 (#1279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfecher @kevaundray