chore(ci): Cache yarn and playwright dependencies in CI #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
tf/yarn-caching
branch
from
8930d70
to
0919c63
Compare
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
|
I'm not clear on why this CI run is failing. Those dependencies it's trying to remove are in the relevant @kobyhallx @phated do you have any ideas? |
|
I've got a minimal reproduction in #2714 |
|
I've found the underlying cause for this issue. |
* tf/split-build-and-test: chore: remove reference to `result` directory chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718) chore: clippy fixes (#2719) chore: fix version querying chore: nits chore(ci): fix playwright caching chore: pass full `package.json` into build artifact chore: clean up straggler `packageManager` chore: remove `packageManager" fields from workspace packages chore: refresh lockfile Update .github/workflows/abi_wasm.yml chore: split build and tests jobs in `abi_wasm.yml` chore: Integrate noir.js into workspace and CI release workflow (#2705) feat: Add initial version of noir.js (#2681) chore: switch `release-source-resolver.yml` to use yarn (#2704) chore: move stranded test to correct directory (#2701) chore(ci): deny wildcard dependencies (#2702) chore: fix `noirc_abi_wasm` publish for release-please (#2699)
kevaundray
previously approved these changes
Sep 15, 2023
kevaundray
approved these changes
Sep 15, 2023
TomAFrench
added a commit
that referenced
this pull request
Sep 15, 2023
* master: chore(ci): Treat clippy warnings as errors in CI (#2684) chore(ci): Cache yarn and playwright dependencies in CI (#2697) chore: Add noir-wasm publishing as a workflow (#2721) fix: failing js tests (#2722) chore: Add deprecation message for default type in for loop (#2689) chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718) chore: clippy fixes (#2719) chore: Integrate noir.js into workspace and CI release workflow (#2705) feat: Add initial version of noir.js (#2681) chore: switch `release-source-resolver.yml` to use yarn (#2704) chore: move stranded test to correct directory (#2701) chore(ci): deny wildcard dependencies (#2702) chore: fix `noirc_abi_wasm` publish for release-please (#2699)
phated
reviewed
Sep 15, 2023
Comment on lines
-11
to
-14
| - name: Install node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18.17.1 |
There was a problem hiding this comment.
You really should be using setup-node to have specific versions of node instead of the outdated one that ships with actions.
Additionally, the setup-node action has the yarn caching directly built-in.
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
) # Description <!-- Thanks for taking the time to improve Noir! --> <!-- Please fill out all fields marked with an asterisk (*). --> ## Problem\* <!-- Describe the problem this Pull Request (PR) resolves / link to the GitHub Issue that describes the problem. --> Resolves <!-- Link to GitHub Issue --> ## Summary\* This PR addresses #2697 (comment) ## Documentation - [ ] This PR requires documentation updates when merged. <!-- If checked, check one of the following: --> - [ ] I will submit a noir-lang/docs PR. <!-- Submit a PR on https://github.com/noir-lang/docs. Thank you! --> - [ ] I will request for and support Dev Rel's help in documenting this PR. <!-- List / highlight what should be documented. --> <!-- Dev Rel will reach out for clarifications when needed. Thank you! --> ## Additional Context <!-- Supplement further information if applicable. --> # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --------- Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.