chore: allow common ascii punctuation in attributes #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambarnes
commented
Dec 8, 2023
kevaundray
approved these changes
Dec 9, 2023
TomAFrench
added a commit
that referenced
this pull request
Dec 11, 2023
* master: (120 commits) feat: allow passing custom foreign call handlers when creating proofs in NoirJS (#3764) fix: add missing assertion to test (#3765) chore: re-export the items needed for the lsp from the fm crate instead of importing codespan_reporting (#3757) chore: remove special casing for `pedersen_hash` black box function (#3744) chore: remove extraneous dbg statement (#3761) chore: fix un-needed fully qualified path (#3755) feat: aztec-packages (#3754) feat: allow underscores in integer literals (#3746) fix: deserialize odd length hex literals (#3747) feat: optimize out unnecessary truncation instructions (#3717) chore: use `tsx` instead of `ts-node` for `noir_js` (#3750) chore(ci): fail `tests-end` job if any dependants failed (#3737) chore: allow common ascii punctuation in attributes (#3733) chore: fix broken onboarding link in README (#3732) feat: Dockerfile to test cargo and JS packages (#3684) feat(lsp): add goto definition for locals (#3705) feat: docs landing page with a playground (#3667) fix: `try_unify` no longer binds types on failure (#3697) fix: parse negative integer literals (#3698) fix: unsigned integers cannot be negated (#3688) ...
AztecBot
pushed a commit
that referenced
this pull request
Dec 19, 2023
- Update the dapp tutorial testing page to not reference the npm setup - Update the testing tutorials page to mention the debug options on waiting for a transaction closes #2913 # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist). --------- Co-authored-by: Cat McGee <helloworld@mcgee.cat> Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
spotted an issue with punctuation inside a
#[test(should_fail_with = "")]block (comment on original issue)Problem*
Resolves #3372 (an extension of this original issue)
Summary*
I built off of the original work done over here #3374 but simplified things down to just cover all common punctuation
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.