Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move module related code from fm to noirc-frontend #3806

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves #3799

Summary*

This is a relatively quick and dirty resolution to #3799. We may want to integrate these functions into ModCollector as methods but I think they also work standalone plus it means that we can transfer the tests across without needing to create a ModCollector instance.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray added this pull request to the merge queue Dec 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 14, 2023
@TomAFrench TomAFrench added this pull request to the merge queue Dec 14, 2023
Merged via the queue into master with commit 49da769 Dec 14, 2023
35 checks passed
@TomAFrench TomAFrench deleted the tf/move-module-code-to-frontend branch December 14, 2023 20:52
AztecBot pushed a commit that referenced this pull request Jan 3, 2024
sirasistant pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move module specific code out of the file manager
2 participants