-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace env-logger
with tracing
#3878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the look of the span feature from tracing
as that simplifies how we were using a lot of our tracing previously.
If we switch over to that + clean up commented deps then I think we can merge assuming the log output looks ok.
Let's do spans in separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
env-logger
with tracing
Description
Problem*
While env-logger concerns itself with logging, tracing is drop in replacement to support logging case but also provides more features for profiling.
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.