Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): install fixed version of wasm-pack in CI #4034

Merged
merged 2 commits into from
Jan 12, 2024
Merged

chore(ci): install fixed version of wasm-pack in CI #4034

merged 2 commits into from
Jan 12, 2024

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Jan 12, 2024 •
edited

Description

Problem*

Resolves

Summary*

Let's provide a fixed version of wasm-pack in CI rather than just allowing yarn to install it when it realises that it doesn't exist.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench changed the title chore(ci): install wasm-opt in CI chore(ci): install fixed version of wasm-pack in CI Jan 12, 2024
kobyhallx
kobyhallx approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TomAFrench TomAFrench added this pull request to the merge queue Jan 12, 2024
Merged via the queue into master with commit 5ff5136 Jan 12, 2024
30 checks passed
@TomAFrench TomAFrench deleted the tf/install-wasm-opt branch January 12, 2024 18:21
TomAFrench added a commit that referenced this pull request Jan 13, 2024
@TomAFrench
Merge branch 'master' into aztec-packages
787ccdc 
* master:
  feat: add `noir-compiler` checks to `aztec_macros` (#4031)
  chore: remove unnecessary visibility modifiers from u128 trait impls (#4023)
  chore(ci): install fixed version of `wasm-pack` in CI (#4034)
  chore: remove `release-tests` package (#4032)
  chore(docs): bumping playground version (#4030)
  fix: allow ast when macro errors (#4005)
  chore: provide a canonical "failing" `BlackBoxFunctionSolver` (#4028)
  feat: assert maximum bit size when creating a U128 from an integer (#4024)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobyhallx kobyhallx kobyhallx approved these changes

@kevaundray kevaundray Awaiting requested review from kevaundray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TomAFrench @kobyhallx