Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test for missing lambda closure environment #4212

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

michaeljklein
Copy link
Contributor

@michaeljklein michaeljklein commented Jan 30, 2024

Description

This issue has been resolved, presumably by github.com//pull/2457, but this test no longer appears to be in the repo so re-adding it to prevent regressions.

Problem*

Resolves #2120

Summary*

This just adds a test.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@michaeljklein michaeljklein changed the title test: add test for missing lambda closure environment (#2120) wip: add test for missing lambda closure environment (#2120) Jan 30, 2024
@michaeljklein michaeljklein changed the title wip: add test for missing lambda closure environment (#2120) chore: add test for missing lambda closure environment (#2120) Feb 1, 2024
@michaeljklein michaeljklein marked this pull request as ready for review February 1, 2024 20:22
@TomAFrench TomAFrench added this pull request to the merge queue Feb 1, 2024
@TomAFrench TomAFrench changed the title chore: add test for missing lambda closure environment (#2120) chore: add test for missing lambda closure environment Feb 1, 2024
Merged via the queue into master with commit 4467ea9 Feb 1, 2024
35 checks passed
@TomAFrench TomAFrench deleted the michaeljklein/missing-closure-env branch February 1, 2024 22:05
TomAFrench added a commit that referenced this pull request Feb 2, 2024
* master: (22 commits)
  feat: remove predicate from `sort` intrinsic function (#4228)
  chore: add test for missing lambda closure environment (#2120) (#4212)
  chore(docs): Updates following `is_recursive` flag removal (#4199)
  fix: from field with constant values (#4226)
  feat: Option expect method (#4219)
  feat: Evaluation of dynamic assert messages (#4101)
  chore(docs): XOR typo in docs (#4223)
  fix: apply range constraints to return values from unconstrained functions (#4217)
  fix(lsp): replace panics with errors (#4209)
  feat: Improve Error Handling for Cargo in Bootstrap Script (#4211)
  fix: prevent declarations of blackbox functions outside of the stdlib (#4177)
  feat: disable unused variable checks on low-level and oracle functions (#4179)
  chore: Rename acir_docs.md to README.md (#4208)
  feat: remove replacement of boolean range opcodes with `AssertZero` opcodes (#4107)
  chore(docs): updating docs to match new recursion interfacee (#4187)
  feat!: Sync commits from `aztec-packages` (#4144)
  feat: multiply first to allow more ACIR gen optimizations (#4201)
  feat: Move bounded_vec into the noir stdlib (#4197)
  chore: simplify marking black box function outputs as solvable (#4194)
  chore(doc): Add docs for `assert_max_bit_size` (#4196)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closure environments aren't added to a closure's parameters
3 participants