Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix dead link in docs #4326

Merged
merged 1 commit into from
Feb 12, 2024
Merged

chore: fix dead link in docs #4326

merged 1 commit into from
Feb 12, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

Not sure why CI didn't catch this on a PR but this link is dead.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 10, 2024
Copy link
Contributor

@TomAFrench TomAFrench requested a review from a team February 11, 2024 00:47
@critesjosh
Copy link
Contributor

Looks like the path changes on the dev version of the docs (0.23.0) for some reason.
This url is currently working on the deployed site. https://noir-lang.org/docs/how_to/solidity_verifier

Since this is on the homepage and not on a versioned section of the docs, will merging this change the deployment immediately? cc @signorecello

@TomAFrench TomAFrench added this pull request to the merge queue Feb 12, 2024
Merged via the queue into master with commit fc32703 Feb 12, 2024
39 checks passed
@TomAFrench TomAFrench deleted the tf/fix-dead-link branch February 12, 2024 09:48
@Savio-Sou
Copy link
Collaborator

Since this is on the homepage and not on a versioned section of the docs, will merging this change the deployment immediately?

Seems ok, clicking into "Generate a Solidity Verifier" on our deployed docs links to https://noir-lang.org/docs/how_to/how-to-solidity-verifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants