Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: separating out array and slice types in the AST #4504

Merged
merged 36 commits into from
Mar 19, 2024
Merged

feat!: separating out array and slice types in the AST #4504

merged 36 commits into from
Mar 19, 2024

Commits on Mar 6, 2024

  1. wip separating out array and slice types in the AST

    @michaeljklein
    michaeljklein committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6951dfb View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Update ordering of Type::Array construction in type_check/expr.rs

    @jfecher
    jfecher committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    2f93bed View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. wip debugging and updating tests: fix parser and parser tests for amp… 

    …ersand, updating stdlib, fixed nested slice for new type, found missing unification case, added more specific error for missing array length, debugging slice parser, added noirc_frontend test for slices, debugging stdlib failing to build
    @michaeljklein
    michaeljklein committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    654732a View commit details
    Browse the repository at this point in the history

  2. wip debugging: test slice index, got slice index working, slice-speci… 

    …fic black box functions, stdlib building
    @michaeljklein
    michaeljklein committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    23d3a72 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. got tests passing, update stdlib methods to take slices, fix missing … 

    …type check case, updating test_programs, defaulting unknown array length to zero, cleanup debugging println, add utf8 decoding and serde error to execution json decoding error message, cargo clippy/fmt
    @michaeljklein
    michaeljklein committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    c683028 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into michaeljklein/separate-slice-ast

    @michaeljklein
    michaeljklein committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    a571593 View commit details
    Browse the repository at this point in the history

  3. update poseidon/mimic hash slice literals, add eq/ord/default instanc… 

    …es for slices, fix slice literal in regression test
    @michaeljklein
    michaeljklein committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    6473805 View commit details
    Browse the repository at this point in the history

  4. added missing element_type_at_index case for slices, fixed all but on… 

    …e debugger error (timeout in brillig_cow_regression)
    @michaeljklein
    michaeljklein committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4f66228 View commit details
    Browse the repository at this point in the history

  5. update slice literal in pedersen_hash wasm example

    @michaeljklein
    michaeljklein committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    cd2807d View commit details
    Browse the repository at this point in the history

  6. remove redundant match on array vs slice

    @michaeljklein
    michaeljklein committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    7a50955 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into michaeljklein/separate-slice-ast

    @michaeljklein
    michaeljklein committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    592b94d View commit details
    Browse the repository at this point in the history

  8. remove unused variable, flip result type order

    @michaeljklein
    michaeljklein committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4adc691 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Merge branch 'master' into michaeljklein/separate-slice-ast

    @michaeljklein
    michaeljklein committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    cad7214 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Merge branch 'master' into michaeljklein/separate-slice-ast

    @michaeljklein
    michaeljklein committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    9cee3e0 View commit details
    Browse the repository at this point in the history

  2. Update noir_stdlib/src/merkle.nr 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @michaeljklein @jfecher
    michaeljklein and jfecher committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    88f53b5 View commit details
    Browse the repository at this point in the history

  3. Update test_programs/compile_success_empty/intrinsic_die/src/main.nr 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @michaeljklein @jfecher
    michaeljklein and jfecher committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    9552626 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into michaeljklein/separate-slice-ast

    @michaeljklein
    michaeljklein committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    5992308 View commit details
    Browse the repository at this point in the history

  5. remove unused slice tests from frontend, fix Eq and Cmp for slices as… 

    …suming same lengths, fix bigint slice literal from master
    @michaeljklein
    michaeljklein committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4214691 View commit details
    Browse the repository at this point in the history

  6. remove unused PartialEq

    @michaeljklein
    michaeljklein committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    370b8ae View commit details
    Browse the repository at this point in the history

  7. add back [hash]_array methods, use those methods in tests/stdlib

    @michaeljklein
    michaeljklein committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    0b59ecc View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into michaeljklein/separate-slice-ast

    @michaeljklein
    michaeljklein committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    41e6ae0 View commit details
    Browse the repository at this point in the history

  9. fix slice literal from merge

    @michaeljklein
    michaeljklein committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    e2fdfa9 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. update docs for slices, fix/remove missing docs links, fix duplicated… 

    … docs links
    @michaeljklein
    michaeljklein committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2a5cb84 View commit details
    Browse the repository at this point in the history

  2. update docs pass: add missing as_slice's, fix old types for stdlib fu… 

    …nctions in docs, document slice literals, doc slice len, add docs for _array hash/verify/trait methods, add missing doc ref for pedersen_commitment_array
    @michaeljklein
    michaeljklein committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    b1302d8 View commit details
    Browse the repository at this point in the history

  3. nargo fmt

    @michaeljklein
    michaeljklein committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    3378b8e View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Update compiler/noirc_frontend/src/ast/mod.rs 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @michaeljklein @jfecher
    michaeljklein and jfecher committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    f56a4db View commit details
    Browse the repository at this point in the history

  2. Update compiler/noirc_frontend/src/hir_def/types.rs 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @michaeljklein @jfecher
    michaeljklein and jfecher committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    be2d631 View commit details
    Browse the repository at this point in the history

  3. Update docs/docs/noir/standard_library/recursion.md 

    Co-authored-by: jfecher <jake@aztecprotocol.com>
    @michaeljklein @jfecher
    michaeljklein and jfecher committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    57375cd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into michaeljklein/separate-slice-ast

    @michaeljklein
    michaeljklein committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ce11dcc View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into michaeljklein/separate-slice-ast

    @jfecher
    jfecher committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4b62efd View commit details
    Browse the repository at this point in the history

  6. fix duplicated error match from merging master, add docs differentiat… 

    …ing slices from references to arrays, switch _array and _slice type defaults and updates docs/tests
    @michaeljklein
    michaeljklein committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    1f9257b View commit details
    Browse the repository at this point in the history

  7. nargo fmt

    @michaeljklein
    michaeljklein committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    bc28b78 View commit details
    Browse the repository at this point in the history

  8. fix array/slice for hash in wasm test

    @michaeljklein
    michaeljklein committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    93a1e02 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into michaeljklein/separate-slice-ast

    @michaeljklein
    michaeljklein committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    d23dda6 View commit details
    Browse the repository at this point in the history

  10. include len in slice's hash, revert broken link fixes (reference fold… 

    …er in docs)
    @michaeljklein
    michaeljklein committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    e2b2ba9 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into michaeljklein/separate-slice-ast

    @michaeljklein
    michaeljklein committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    7197b9c View commit details
    Browse the repository at this point in the history