-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sync from aztec-packages #4670
Merged
Merged
Commits on Mar 28, 2024
-
refactor: inject fetcher instead of using global (AztecProtocol/aztec…
…-packages#5502) This PR refactors the GithubDependencyResolver to take a fetch implementation instead of always using the global default
Configuration menu - View commit details
-
Copy full SHA for a62e972 - Browse repository at this point
Copy the full SHA a62e972View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bbe4a6 - Browse repository at this point
Copy the full SHA 3bbe4a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 485cbb5 - Browse repository at this point
Copy the full SHA 485cbb5View commit details
Commits on Mar 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d3bdfb7 - Browse repository at this point
Copy the full SHA d3bdfb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60155f2 - Browse repository at this point
Copy the full SHA 60155f2View commit details -
feat(acvm): Execute multiple circuits (AztecProtocol/aztec-packages#5380
) Resolves #4428 This is a followup to AztecProtocol/aztec-packages#5341 which does the initial ACIR generation work for multiple ACIR functions. Execution is now done by moving `execute_circuit` to be part of a stateful `ProgramExecutor` that builds a witness stack for every completed `execute_circuit` call. An initial `execute_program` function instantiates the `ProgramExecutor` and starts execution on our `main` entry point circuit. When a `Call` opcode is reached we pause execution and recursively call `execute_circuit`, which then returns the solved witness for that call. We then resolve the outputs of that execution by reading the return witnesses from the inner solved witness. We then push the nested call solved witness onto the witness stack and continue execution of our main ACVM instance. This is quite similar to the process used by foreign calls with Brillig, except it is now done with the main ACVM rather than the contained Brillig VM. This witness stack and program (list of `Circuit` functions) then gets passed to the backend. For now, I have only done an additive `prove_and_verify_ultra_honk_program` to show the process working for the basic non-inlined ACIR programs supplied here. I wanted to leave any WASM exports or ACVM JS changes for a follow-up PR as they are quite a bit of changes on their own. --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Tom French <tom@tomfren.ch> Co-authored-by: jfecher <jfecher11@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9d150d9 - Browse repository at this point
Copy the full SHA 9d150d9View commit details -
feat(acvm): Execute multiple circuits (AztecProtocol/aztec-packages#5380
) Resolves #4428 This is a followup to AztecProtocol/aztec-packages#5341 which does the initial ACIR generation work for multiple ACIR functions. Execution is now done by moving `execute_circuit` to be part of a stateful `ProgramExecutor` that builds a witness stack for every completed `execute_circuit` call. An initial `execute_program` function instantiates the `ProgramExecutor` and starts execution on our `main` entry point circuit. When a `Call` opcode is reached we pause execution and recursively call `execute_circuit`, which then returns the solved witness for that call. We then resolve the outputs of that execution by reading the return witnesses from the inner solved witness. We then push the nested call solved witness onto the witness stack and continue execution of our main ACVM instance. This is quite similar to the process used by foreign calls with Brillig, except it is now done with the main ACVM rather than the contained Brillig VM. This witness stack and program (list of `Circuit` functions) then gets passed to the backend. For now, I have only done an additive `prove_and_verify_ultra_honk_program` to show the process working for the basic non-inlined ACIR programs supplied here. I wanted to leave any WASM exports or ACVM JS changes for a follow-up PR as they are quite a bit of changes on their own. --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Tom French <tom@tomfren.ch> Co-authored-by: jfecher <jfecher11@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e625c7e - Browse repository at this point
Copy the full SHA e625c7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d0edf6 - Browse repository at this point
Copy the full SHA 2d0edf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1366b6 - Browse repository at this point
Copy the full SHA c1366b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 865f4aa - Browse repository at this point
Copy the full SHA 865f4aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02bf542 - Browse repository at this point
Copy the full SHA 02bf542View commit details -
Configuration menu - View commit details
-
Copy full SHA for 683976e - Browse repository at this point
Copy the full SHA 683976eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfc3ef7 - Browse repository at this point
Copy the full SHA bfc3ef7View commit details -
Configuration menu - View commit details
-
Copy full SHA for aba4ee5 - Browse repository at this point
Copy the full SHA aba4ee5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.