Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): comptime globals #4918

Merged
merged 17 commits into from
Apr 29, 2024
Merged

feat(experimental): comptime globals #4918

merged 17 commits into from
Apr 29, 2024

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    275855b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fe8e399 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e2e119a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e3d7a14 View commit details
    Browse the repository at this point in the history
  5. Push error

    jfecher committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    899c72e View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Configuration menu
    Copy the full SHA
    0c10d3b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7cdfa2c View commit details
    Browse the repository at this point in the history
  3. fmt

    jfecher committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    fb98f14 View commit details
    Browse the repository at this point in the history
  4. Fix test helpers

    jfecher committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    71b6b01 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    73357da View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2487e6a View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    8c774f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    3d19e1f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d59e1f8 View commit details
    Browse the repository at this point in the history
  3. Fix merge

    jfecher committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    cfc2bef View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    59861cf View commit details
    Browse the repository at this point in the history
  5. feat(experimental): Implement comptime mut globals (#4926)

    # Description
    
    ## Problem\*
    
    Resolves #4917 
    
    ## Summary\*
    
    Implements mutable comptime globals
    
    ## Additional Context
    
    Changes should be relatively straightforward - mostly parser changes to
    add parsing `mut` to globals, resolution changes to track this and error
    if the global is not also comptime, etc. The one bug that was fixed is
    that globals were being re-evaluated in the interpreter each time which
    would reset their value whenever they were referenced. This has been
    fixed with a lookup check.
    
    ## Documentation\*
    
    Check one:
    - [ ] No documentation needed.
    - [ ] Documentation included in this PR.
    - [x] **[For Experimental Features]** Documentation to be submitted in a
    separate PR.
    
    # PR Checklist\*
    
    - [x] I have tested the changes locally.
    - [ ] I have formatted the changes with [Prettier](https://prettier.io/)
    and/or `cargo fmt` on default settings.
    
    ---------
    
    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    jfecher and TomAFrench committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    dc90de9 View commit details
    Browse the repository at this point in the history