feat: add Neg trait to stdlib
#4983
Merged
+41
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
jfecher
approved these changes
May 6, 2024
|
🚀 Deployed on https://66390c5c669e3d094d31589f--noir-docs.netlify.app |
|
FYI @noir-lang/developerrelations on Noir doc changes. |
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 7, 2024
noir-lang/noir#4971) fix: Compute the correct slice length when coercing from a literal array of complex types (noir-lang/noir#4986) feat: add `Neg` trait to stdlib (noir-lang/noir#4983) feat: implement `From` array trait for `BoundedVec` (noir-lang/noir#4927) chore: Release Noir(0.29.0) (noir-lang/noir#4905) fix: Move remove_if_else pass after second inlining (noir-lang/noir#4976)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 7, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix: set index and value to 0 for array_get with predicate (noir-lang/noir#4971) fix: Compute the correct slice length when coercing from a literal array of complex types (noir-lang/noir#4986) feat: add `Neg` trait to stdlib (noir-lang/noir#4983) feat: implement `From` array trait for `BoundedVec` (noir-lang/noir#4927) chore: Release Noir(0.29.0) (noir-lang/noir#4905) fix: Move remove_if_else pass after second inlining (noir-lang/noir#4976) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <tom@tomfren.ch>
This was referenced May 7, 2024
TomAFrench
added a commit
that referenced
this pull request
May 8, 2024
* master: (41 commits) fix: defer overflow checks for unsigned integers to acir-gen (#4832) feat: add support for u16/i16 (#4985) chore: split `ops` into `arith` and `bit` modules (#4989) chore(ci): run clippy on benchmarks (#4988) feat: remove query to backend to get expression width (#4975) fix: set index and value to 0 for array_get with predicate (#4971) fix: Compute the correct slice length when coercing from a literal array of complex types (#4986) feat: add `Neg` trait to stdlib (#4983) feat: implement `From` array trait for `BoundedVec` (#4927) chore: Release Noir(0.29.0) (#4905) fix: Move remove_if_else pass after second inlining (#4976) feat: Optimize array sets in if conditions (alternate version) (#4716) chore: rename instruction checks for side effects (#4945) chore: Switch Noir JS to use execute program instead of circuit (#4965) fix: Use annotated type when checking declaration (#4966) feat: handle empty response foreign calls without an external resolver (#4959) feat: Complex outputs from acir call (#4952) fix: Require for all foldable functions to use distinct return (#4949) feat!: use `distinct` return value witnesses by default (#4951) chore(docs): adding matomo tracking (#4898) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR implements the
std::op::Negtrait so that we can implementSubonEmbeddedCurvePointAdditional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.BEGIN_COMMIT_OVERRIDE
feat: add
std::ops::Negtrait to stdlibfeat: implement
std::ops::SubonEmbeddedCurvePointEND_COMMIT_OVERRIDE