fix: update in_contract flag before handling function metadata in elaborator
#5292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
reviewed
Jun 20, 2024
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jun 20, 2024
…etadata in elaborator (noir-lang/noir#5292) fix: fix incorrect return type being applied to stdlib functions `modulus_be_bytes()`, `modulus_be_bits()`, etc. (noir-lang/noir#5278) chore: refactor test case generation in build.rs (noir-lang/noir#5280) fix: handle struct with nested arrays in oracle return values (noir-lang/noir#5244) feat: build simple dictionary from inspecting ACIR program (noir-lang/noir#5264) fix: Add more thorough check for whether a type is valid when passing it from constrained code to unconstrained code (noir-lang/noir#5009) chore: Pedersen commitment in Noir (noir-lang/noir#5221) chore: pedersen hash in Noir (noir-lang/noir#5217) fix: Don't lazily elaborate functions (noir-lang/noir#5282) fix: avoid unnecessarily splitting expressions with multiplication terms with a shared term (noir-lang/noir#5291) fix: avoid duplicating constant arrays (noir-lang/noir#5287) feat: add fuzzer for Noir programs (noir-lang/noir#5251) feat: Run `comptime` code from annotations on a type definition (noir-lang/noir#5256) feat: implement comptime support for `as_slice` builtin (noir-lang/noir#5276) chore: create separate crate just for noir artifacts (noir-lang/noir#5162) feat: add support for wildcard types (noir-lang/noir#5275) chore: replace logical operators with bitwise in `DebugToString` (noir-lang/noir#5236) fix: use proper serialization in `AbiValue` (noir-lang/noir#5270) chore: simplify compilation flow to write to file immediately (noir-lang/noir#5265) feat: implement comptime support for `array_len` builtin (noir-lang/noir#5272) chore: Use the elaborator by default (noir-lang/noir#5246) chore: Release Noir(0.31.0) (noir-lang/noir#5166) feat!: remove `dep::` prefix (noir-lang/noir#4946) feat: Sync from aztec-packages (noir-lang/noir#5242) chore: replace `is_bn254` implementation to not rely on truncation of literals (noir-lang/noir#5247) chore: add no-predicate to hash implementations (noir-lang/noir#5253) feat(experimental): Implement macro calls & splicing into `Expr` values (noir-lang/noir#5203) feat: add BoundedVec::map (noir-lang/noir#5250) chore: add no predicate to poseidon2 (noir-lang/noir#5252) feat: add `set` and `set_unchecked` methods to `Vec` and `BoundedVec` (noir-lang/noir#5241) fix: Disable `if` optimization (noir-lang/noir#5240) chore: redo typo PR by dropbigfish (noir-lang/noir#5234) chore: add property tests for ABI encoding (noir-lang/noir#5216) chore: thread generics through ACIR/brillig gen (noir-lang/noir#5120) chore: copy across typo PR script from aztec-packages (noir-lang/noir#5235) chore(docs): fixing trailing slash issue (noir-lang/noir#5233) fix: add support for nested arrays returned by oracles (noir-lang/noir#5132) chore: Parse macros (noir-lang/noir#5229) chore: Optimize the elaborator (noir-lang/noir#5230) fix(elaborator): Fix regression introduced by lazy-global changes (noir-lang/noir#5223) fix(elaborator): Fix duplicate methods error (noir-lang/noir#5225) chore: fixing all relative paths (noir-lang/noir#5220) chore: push code related to ABI gen into `noirc_driver` (noir-lang/noir#5218)
5 tasks
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jun 21, 2024
…t of a function (noir-lang/noir#5303) fix: update `in_contract` flag before handling function metadata in elaborator (noir-lang/noir#5292) fix: fix incorrect return type being applied to stdlib functions `modulus_be_bytes()`, `modulus_be_bits()`, etc. (noir-lang/noir#5278) chore: refactor test case generation in build.rs (noir-lang/noir#5280) fix: handle struct with nested arrays in oracle return values (noir-lang/noir#5244) feat: build simple dictionary from inspecting ACIR program (noir-lang/noir#5264) fix: Add more thorough check for whether a type is valid when passing it from constrained code to unconstrained code (noir-lang/noir#5009) chore: Pedersen commitment in Noir (noir-lang/noir#5221) chore: pedersen hash in Noir (noir-lang/noir#5217) fix: Don't lazily elaborate functions (noir-lang/noir#5282) fix: avoid unnecessarily splitting expressions with multiplication terms with a shared term (noir-lang/noir#5291) fix: avoid duplicating constant arrays (noir-lang/noir#5287) feat: add fuzzer for Noir programs (noir-lang/noir#5251) feat: Run `comptime` code from annotations on a type definition (noir-lang/noir#5256) feat: implement comptime support for `as_slice` builtin (noir-lang/noir#5276) chore: create separate crate just for noir artifacts (noir-lang/noir#5162) feat: add support for wildcard types (noir-lang/noir#5275) chore: replace logical operators with bitwise in `DebugToString` (noir-lang/noir#5236) fix: use proper serialization in `AbiValue` (noir-lang/noir#5270) chore: simplify compilation flow to write to file immediately (noir-lang/noir#5265) feat: implement comptime support for `array_len` builtin (noir-lang/noir#5272) chore: Use the elaborator by default (noir-lang/noir#5246) chore: Release Noir(0.31.0) (noir-lang/noir#5166) feat!: remove `dep::` prefix (noir-lang/noir#4946) feat: Sync from aztec-packages (noir-lang/noir#5242) chore: replace `is_bn254` implementation to not rely on truncation of literals (noir-lang/noir#5247) chore: add no-predicate to hash implementations (noir-lang/noir#5253) feat(experimental): Implement macro calls & splicing into `Expr` values (noir-lang/noir#5203) feat: add BoundedVec::map (noir-lang/noir#5250) chore: add no predicate to poseidon2 (noir-lang/noir#5252) feat: add `set` and `set_unchecked` methods to `Vec` and `BoundedVec` (noir-lang/noir#5241) fix: Disable `if` optimization (noir-lang/noir#5240) chore: redo typo PR by dropbigfish (noir-lang/noir#5234) chore: add property tests for ABI encoding (noir-lang/noir#5216) chore: thread generics through ACIR/brillig gen (noir-lang/noir#5120) chore: copy across typo PR script from aztec-packages (noir-lang/noir#5235) chore(docs): fixing trailing slash issue (noir-lang/noir#5233) fix: add support for nested arrays returned by oracles (noir-lang/noir#5132) chore: Parse macros (noir-lang/noir#5229) chore: Optimize the elaborator (noir-lang/noir#5230) fix(elaborator): Fix regression introduced by lazy-global changes (noir-lang/noir#5223) fix(elaborator): Fix duplicate methods error (noir-lang/noir#5225) chore: fixing all relative paths (noir-lang/noir#5220) chore: push code related to ABI gen into `noirc_driver` (noir-lang/noir#5218)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jun 24, 2024
…21) (noir-lang/noir#5318) fix: skip emission of brillig calls which will never be executed (noir-lang/noir#5314) feat: Make macros operate on token streams instead of AST nodes (noir-lang/noir#5301) chore: Bundle SSA Evaluator Options (noir-lang/noir#5317) fix: Replace panic in monomorphization with an error (noir-lang/noir#5305) fix(nargo_fmt): Account for spaces before the generic list of a function (noir-lang/noir#5303) fix: update `in_contract` flag before handling function metadata in elaborator (noir-lang/noir#5292) fix: fix incorrect return type being applied to stdlib functions `modulus_be_bytes()`, `modulus_be_bits()`, etc. (noir-lang/noir#5278) chore: refactor test case generation in build.rs (noir-lang/noir#5280) fix: handle struct with nested arrays in oracle return values (noir-lang/noir#5244) feat: build simple dictionary from inspecting ACIR program (noir-lang/noir#5264) fix: Add more thorough check for whether a type is valid when passing it from constrained code to unconstrained code (noir-lang/noir#5009) chore: Pedersen commitment in Noir (noir-lang/noir#5221) chore: pedersen hash in Noir (noir-lang/noir#5217) fix: Don't lazily elaborate functions (noir-lang/noir#5282) fix: avoid unnecessarily splitting expressions with multiplication terms with a shared term (noir-lang/noir#5291) fix: avoid duplicating constant arrays (noir-lang/noir#5287) feat: add fuzzer for Noir programs (noir-lang/noir#5251) feat: Run `comptime` code from annotations on a type definition (noir-lang/noir#5256) feat: implement comptime support for `as_slice` builtin (noir-lang/noir#5276) chore: create separate crate just for noir artifacts (noir-lang/noir#5162) feat: add support for wildcard types (noir-lang/noir#5275) chore: replace logical operators with bitwise in `DebugToString` (noir-lang/noir#5236) fix: use proper serialization in `AbiValue` (noir-lang/noir#5270) chore: simplify compilation flow to write to file immediately (noir-lang/noir#5265) feat: implement comptime support for `array_len` builtin (noir-lang/noir#5272) chore: Use the elaborator by default (noir-lang/noir#5246) chore: Release Noir(0.31.0) (noir-lang/noir#5166) feat!: remove `dep::` prefix (noir-lang/noir#4946) feat: Sync from aztec-packages (noir-lang/noir#5242) chore: replace `is_bn254` implementation to not rely on truncation of literals (noir-lang/noir#5247) chore: add no-predicate to hash implementations (noir-lang/noir#5253) feat(experimental): Implement macro calls & splicing into `Expr` values (noir-lang/noir#5203) feat: add BoundedVec::map (noir-lang/noir#5250) chore: add no predicate to poseidon2 (noir-lang/noir#5252) feat: add `set` and `set_unchecked` methods to `Vec` and `BoundedVec` (noir-lang/noir#5241) fix: Disable `if` optimization (noir-lang/noir#5240) chore: redo typo PR by dropbigfish (noir-lang/noir#5234) chore: add property tests for ABI encoding (noir-lang/noir#5216) chore: thread generics through ACIR/brillig gen (noir-lang/noir#5120) chore: copy across typo PR script from aztec-packages (noir-lang/noir#5235) chore(docs): fixing trailing slash issue (noir-lang/noir#5233) fix: add support for nested arrays returned by oracles (noir-lang/noir#5132) chore: Parse macros (noir-lang/noir#5229) chore: Optimize the elaborator (noir-lang/noir#5230) fix(elaborator): Fix regression introduced by lazy-global changes (noir-lang/noir#5223) fix(elaborator): Fix duplicate methods error (noir-lang/noir#5225) chore: fixing all relative paths (noir-lang/noir#5220) chore: push code related to ABI gen into `noirc_driver` (noir-lang/noir#5218)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jun 24, 2024
…21) (noir-lang/noir#5318) fix: skip emission of brillig calls which will never be executed (noir-lang/noir#5314) feat: Make macros operate on token streams instead of AST nodes (noir-lang/noir#5301) chore: Bundle SSA Evaluator Options (noir-lang/noir#5317) fix: Replace panic in monomorphization with an error (noir-lang/noir#5305) fix(nargo_fmt): Account for spaces before the generic list of a function (noir-lang/noir#5303) fix: update `in_contract` flag before handling function metadata in elaborator (noir-lang/noir#5292) fix: fix incorrect return type being applied to stdlib functions `modulus_be_bytes()`, `modulus_be_bits()`, etc. (noir-lang/noir#5278) chore: refactor test case generation in build.rs (noir-lang/noir#5280) fix: handle struct with nested arrays in oracle return values (noir-lang/noir#5244) feat: build simple dictionary from inspecting ACIR program (noir-lang/noir#5264) fix: Add more thorough check for whether a type is valid when passing it from constrained code to unconstrained code (noir-lang/noir#5009) chore: Pedersen commitment in Noir (noir-lang/noir#5221) chore: pedersen hash in Noir (noir-lang/noir#5217) fix: Don't lazily elaborate functions (noir-lang/noir#5282) fix: avoid unnecessarily splitting expressions with multiplication terms with a shared term (noir-lang/noir#5291) fix: avoid duplicating constant arrays (noir-lang/noir#5287) feat: add fuzzer for Noir programs (noir-lang/noir#5251) feat: Run `comptime` code from annotations on a type definition (noir-lang/noir#5256) feat: implement comptime support for `as_slice` builtin (noir-lang/noir#5276) chore: create separate crate just for noir artifacts (noir-lang/noir#5162) feat: add support for wildcard types (noir-lang/noir#5275) chore: replace logical operators with bitwise in `DebugToString` (noir-lang/noir#5236) fix: use proper serialization in `AbiValue` (noir-lang/noir#5270) chore: simplify compilation flow to write to file immediately (noir-lang/noir#5265) feat: implement comptime support for `array_len` builtin (noir-lang/noir#5272) chore: Use the elaborator by default (noir-lang/noir#5246) chore: Release Noir(0.31.0) (noir-lang/noir#5166) feat!: remove `dep::` prefix (noir-lang/noir#4946) feat: Sync from aztec-packages (noir-lang/noir#5242) chore: replace `is_bn254` implementation to not rely on truncation of literals (noir-lang/noir#5247) chore: add no-predicate to hash implementations (noir-lang/noir#5253) feat(experimental): Implement macro calls & splicing into `Expr` values (noir-lang/noir#5203) feat: add BoundedVec::map (noir-lang/noir#5250) chore: add no predicate to poseidon2 (noir-lang/noir#5252) feat: add `set` and `set_unchecked` methods to `Vec` and `BoundedVec` (noir-lang/noir#5241) fix: Disable `if` optimization (noir-lang/noir#5240) chore: redo typo PR by dropbigfish (noir-lang/noir#5234) chore: add property tests for ABI encoding (noir-lang/noir#5216) chore: thread generics through ACIR/brillig gen (noir-lang/noir#5120) chore: copy across typo PR script from aztec-packages (noir-lang/noir#5235) chore(docs): fixing trailing slash issue (noir-lang/noir#5233) fix: add support for nested arrays returned by oracles (noir-lang/noir#5132) chore: Parse macros (noir-lang/noir#5229) chore: Optimize the elaborator (noir-lang/noir#5230) fix(elaborator): Fix regression introduced by lazy-global changes (noir-lang/noir#5223) fix(elaborator): Fix duplicate methods error (noir-lang/noir#5225) chore: fixing all relative paths (noir-lang/noir#5220) chore: push code related to ABI gen into `noirc_driver` (noir-lang/noir#5218)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
# Description ## Problem\* Resolves <!-- Link to GitHub Issue --> ## Summary\* Followup to #5292 to handle globals as well ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
TomAFrench
added a commit
that referenced
this pull request
Jun 25, 2024
* master: (416 commits) chore: replace cached `in_contract` with `in_contract()` method (#5324) fix: fix usage of `#[abi(tag)]` attribute with elaborator (#5298) fix: don't benchmark the "prove" command as it doesn't exist anymore (#5323) feat(stdlib): Update stdlib to use explicit numeric generics (#5306) feat: let `should_fail_with` check that the failure reason contains the expected message (#5319) chore: bump `bb` to 0.43.0 (#5321) feat(frontend): Explicit numeric generics and type kinds (#5155) feat(frontend): Where clause on impl (#5320) chore: add back Pedersen blackbox functions (revert PR 5221) (#5318) fix: skip emission of brillig calls which will never be executed (#5314) feat: Make macros operate on token streams instead of AST nodes (#5301) chore: Bundle SSA Evaluator Options (#5317) fix: Replace panic in monomorphization with an error (#5305) fix(nargo_fmt): Account for spaces before the generic list of a function (#5303) fix: update `in_contract` flag before handling function metadata in elaborator (#5292) fix: fix incorrect return type being applied to stdlib functions `modulus_be_bytes()`, `modulus_be_bits()`, etc. (#5278) chore: refactor test case generation in build.rs (#5280) fix: handle struct with nested arrays in oracle return values (#5244) feat: build simple dictionary from inspecting ACIR program (#5264) fix: Add more thorough check for whether a type is valid when passing it from constrained code to unconstrained code (#5009) ...
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jun 27, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: add back Pedersen blackbox functions (revert PR 5221) (noir-lang/noir#5318) fix: skip emission of brillig calls which will never be executed (noir-lang/noir#5314) feat: Make macros operate on token streams instead of AST nodes (noir-lang/noir#5301) chore: Bundle SSA Evaluator Options (noir-lang/noir#5317) fix: Replace panic in monomorphization with an error (noir-lang/noir#5305) fix(nargo_fmt): Account for spaces before the generic list of a function (noir-lang/noir#5303) fix: update `in_contract` flag before handling function metadata in elaborator (noir-lang/noir#5292) fix: fix incorrect return type being applied to stdlib functions `modulus_be_bytes()`, `modulus_be_bits()`, etc. (noir-lang/noir#5278) chore: refactor test case generation in build.rs (noir-lang/noir#5280) fix: handle struct with nested arrays in oracle return values (noir-lang/noir#5244) feat: build simple dictionary from inspecting ACIR program (noir-lang/noir#5264) fix: Add more thorough check for whether a type is valid when passing it from constrained code to unconstrained code (noir-lang/noir#5009) chore: Pedersen commitment in Noir (noir-lang/noir#5221) chore: pedersen hash in Noir (noir-lang/noir#5217) fix: Don't lazily elaborate functions (noir-lang/noir#5282) fix: avoid unnecessarily splitting expressions with multiplication terms with a shared term (noir-lang/noir#5291) fix: avoid duplicating constant arrays (noir-lang/noir#5287) feat: add fuzzer for Noir programs (noir-lang/noir#5251) feat: Run `comptime` code from annotations on a type definition (noir-lang/noir#5256) feat: implement comptime support for `as_slice` builtin (noir-lang/noir#5276) chore: create separate crate just for noir artifacts (noir-lang/noir#5162) feat: add support for wildcard types (noir-lang/noir#5275) chore: replace logical operators with bitwise in `DebugToString` (noir-lang/noir#5236) fix: use proper serialization in `AbiValue` (noir-lang/noir#5270) chore: simplify compilation flow to write to file immediately (noir-lang/noir#5265) feat: implement comptime support for `array_len` builtin (noir-lang/noir#5272) chore: Use the elaborator by default (noir-lang/noir#5246) chore: Release Noir(0.31.0) (noir-lang/noir#5166) feat!: remove `dep::` prefix (noir-lang/noir#4946) feat: Sync from aztec-packages (noir-lang/noir#5242) chore: replace `is_bn254` implementation to not rely on truncation of literals (noir-lang/noir#5247) chore: add no-predicate to hash implementations (noir-lang/noir#5253) feat(experimental): Implement macro calls & splicing into `Expr` values (noir-lang/noir#5203) feat: add BoundedVec::map (noir-lang/noir#5250) chore: add no predicate to poseidon2 (noir-lang/noir#5252) feat: add `set` and `set_unchecked` methods to `Vec` and `BoundedVec` (noir-lang/noir#5241) fix: Disable `if` optimization (noir-lang/noir#5240) chore: redo typo PR by dropbigfish (noir-lang/noir#5234) chore: add property tests for ABI encoding (noir-lang/noir#5216) chore: thread generics through ACIR/brillig gen (noir-lang/noir#5120) chore: copy across typo PR script from aztec-packages (noir-lang/noir#5235) chore(docs): fixing trailing slash issue (noir-lang/noir#5233) fix: add support for nested arrays returned by oracles (noir-lang/noir#5132) chore: Parse macros (noir-lang/noir#5229) chore: Optimize the elaborator (noir-lang/noir#5230) fix(elaborator): Fix regression introduced by lazy-global changes (noir-lang/noir#5223) fix(elaborator): Fix duplicate methods error (noir-lang/noir#5225) chore: fixing all relative paths (noir-lang/noir#5220) chore: push code related to ABI gen into `noirc_driver` (noir-lang/noir#5218) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: TomAFrench <tom@tomfren.ch>
AztecBot
added a commit
to AztecProtocol/aztec-nr
that referenced
this pull request
Jun 28, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: add back Pedersen blackbox functions (revert PR 5221) (noir-lang/noir#5318) fix: skip emission of brillig calls which will never be executed (noir-lang/noir#5314) feat: Make macros operate on token streams instead of AST nodes (noir-lang/noir#5301) chore: Bundle SSA Evaluator Options (noir-lang/noir#5317) fix: Replace panic in monomorphization with an error (noir-lang/noir#5305) fix(nargo_fmt): Account for spaces before the generic list of a function (noir-lang/noir#5303) fix: update `in_contract` flag before handling function metadata in elaborator (noir-lang/noir#5292) fix: fix incorrect return type being applied to stdlib functions `modulus_be_bytes()`, `modulus_be_bits()`, etc. (noir-lang/noir#5278) chore: refactor test case generation in build.rs (noir-lang/noir#5280) fix: handle struct with nested arrays in oracle return values (noir-lang/noir#5244) feat: build simple dictionary from inspecting ACIR program (noir-lang/noir#5264) fix: Add more thorough check for whether a type is valid when passing it from constrained code to unconstrained code (noir-lang/noir#5009) chore: Pedersen commitment in Noir (noir-lang/noir#5221) chore: pedersen hash in Noir (noir-lang/noir#5217) fix: Don't lazily elaborate functions (noir-lang/noir#5282) fix: avoid unnecessarily splitting expressions with multiplication terms with a shared term (noir-lang/noir#5291) fix: avoid duplicating constant arrays (noir-lang/noir#5287) feat: add fuzzer for Noir programs (noir-lang/noir#5251) feat: Run `comptime` code from annotations on a type definition (noir-lang/noir#5256) feat: implement comptime support for `as_slice` builtin (noir-lang/noir#5276) chore: create separate crate just for noir artifacts (noir-lang/noir#5162) feat: add support for wildcard types (noir-lang/noir#5275) chore: replace logical operators with bitwise in `DebugToString` (noir-lang/noir#5236) fix: use proper serialization in `AbiValue` (noir-lang/noir#5270) chore: simplify compilation flow to write to file immediately (noir-lang/noir#5265) feat: implement comptime support for `array_len` builtin (noir-lang/noir#5272) chore: Use the elaborator by default (noir-lang/noir#5246) chore: Release Noir(0.31.0) (noir-lang/noir#5166) feat!: remove `dep::` prefix (noir-lang/noir#4946) feat: Sync from aztec-packages (noir-lang/noir#5242) chore: replace `is_bn254` implementation to not rely on truncation of literals (noir-lang/noir#5247) chore: add no-predicate to hash implementations (noir-lang/noir#5253) feat(experimental): Implement macro calls & splicing into `Expr` values (noir-lang/noir#5203) feat: add BoundedVec::map (noir-lang/noir#5250) chore: add no predicate to poseidon2 (noir-lang/noir#5252) feat: add `set` and `set_unchecked` methods to `Vec` and `BoundedVec` (noir-lang/noir#5241) fix: Disable `if` optimization (noir-lang/noir#5240) chore: redo typo PR by dropbigfish (noir-lang/noir#5234) chore: add property tests for ABI encoding (noir-lang/noir#5216) chore: thread generics through ACIR/brillig gen (noir-lang/noir#5120) chore: copy across typo PR script from aztec-packages (noir-lang/noir#5235) chore(docs): fixing trailing slash issue (noir-lang/noir#5233) fix: add support for nested arrays returned by oracles (noir-lang/noir#5132) chore: Parse macros (noir-lang/noir#5229) chore: Optimize the elaborator (noir-lang/noir#5230) fix(elaborator): Fix regression introduced by lazy-global changes (noir-lang/noir#5223) fix(elaborator): Fix duplicate methods error (noir-lang/noir#5225) chore: fixing all relative paths (noir-lang/noir#5220) chore: push code related to ABI gen into `noirc_driver` (noir-lang/noir#5218) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: TomAFrench <tom@tomfren.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Description
Problem*
Resolves #5288
Summary*
This PR fixes #5288 by updating
self.in_contractbefore we define function metadata to matchself.local_module. This is mildly hacky and we may want to have a nicer "switch modules and update everything which depends on it" helper function in future.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.