Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Swagger UI 3.2.2 #338

Closed
wants to merge 1 commit into from
Closed

Update to Swagger UI 3.2.2 #338

wants to merge 1 commit into from

Conversation

pytgaen
Copy link

@pytgaen pytgaen commented Oct 11, 2017

Change to use Swagger UI 3.2.2 (to use very soon, the Authorize button ;-))

Copy link
Owner

@noirbizarre noirbizarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks, but I can't merge it in the current state:

  • the split between style, js and template disappeared: it allows to provide custom template without having to redeclare all dependencies. Those using this feature (including myself) lose a feature
  • all configuration pa rameters previously given to Swagger have been removed
  • there is new hard-coded dependency on external Google Font => No more offline use
  • inline style and svg prevent reuse outside this template

Is this a first start, do you plan to reapply these changes or do I need to do it myself ? (Just so I know and avoid doing the same work that you are already doing)

Copy link
Owner

@noirbizarre noirbizarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks, but I can't merge it in the current state:

  • the split between style, js and template disappeared: it allows to provide custom template without having to redeclare all dependencies. Those using this feature (including myself) lose a feature
  • all configuration pa rameters previously given to Swagger have been removed
  • there is new hard-coded dependency on external Google Font => No more offline use
  • inline style and svg prevent reuse outside this template

Do you plan to reapply these changes or do I need to do it myself ? (Just so I know and avoid doing the same work that you are already doing)

@dhofstetter
Copy link

Any plans to upgrade to swagger-ui 3.x ... There are a lot of things improved as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants