check if entryList is empty instead of checking "if (fe)" since the b…

…ehavior of front() can be undefined if the vec is empty Signed-off-by: Gautam Venkataramanan <gautam.chennai@gmail.com>
noironetworks · May 27, 2020 · 0c1f33d · 0c1f33d
1 parent afd403e
commit 0c1f33d
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/agent-ovs/ovs/test/include/PolicyStatsManagerFixture.h b/agent-ovs/ovs/test/include/PolicyStatsManagerFixture.h
@@ -251,9 +251,8 @@ class PolicyStatsManagerFixture : public FlowManagerFixture {
 
         // generate flow removed message for the first flow
         // found in the flow entry list
-        const FlowEntryPtr& fe = entryList.front();
-        if (fe) {
-
+        if (!entryList.empty()) {
+            const FlowEntryPtr& fe = entryList.front();
             fs = &fstat;
             bzero(fs, sizeof(struct ofputil_flow_removed));
             fs->table_id = table_id;