Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC: Memory and perf improvements #216

Merged
merged 2 commits into from
Sep 21, 2023
Merged

CC: Memory and perf improvements #216

merged 2 commits into from
Sep 21, 2023

Conversation

carlosgjs
Copy link
Collaborator

Two main changes:

  • Move the processing of a timespan (e.g. day) into a function and use a new ThreadPoolExecutor every time for better memory cleanup
  • Process the paths so the check for already done correlations can be done in O(1) time

Test processing 3 days show memory steady:
image

@carlosgjs carlosgjs temporarily deployed to github-pages September 20, 2023 19:58 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Patch coverage: 63.50% and project coverage change: +8.10% 🎉

Comparison is base (97326b4) 50.59% compared to head (27f5715) 58.70%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   50.59%   58.70%   +8.10%     
==========================================
  Files          32       32              
  Lines        3751     3819      +68     
  Branches      522      528       +6     
==========================================
+ Hits         1898     2242     +344     
+ Misses       1793     1465     -328     
- Partials       60      112      +52     
Files Changed Coverage Δ
src/noisepy/seis/main.py 43.75% <6.66%> (-1.58%) ⬇️
src/noisepy/seis/scheduler.py 36.58% <11.11%> (-0.73%) ⬇️
src/noisepy/seis/utils.py 92.75% <60.00%> (+13.06%) ⬆️
src/noisepy/seis/correlate.py 75.20% <77.77%> (+58.46%) ⬆️
src/noisepy/seis/constants.py 100.00% <100.00%> (ø)
src/noisepy/seis/hierarchicalstores.py 88.65% <100.00%> (ø)
src/noisepy/seis/numpystore.py 100.00% <100.00%> (ø)
src/noisepy/seis/zarrstore.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@niyiyu niyiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you !

@carlosgjs carlosgjs temporarily deployed to github-pages September 20, 2023 23:48 — with GitHub Actions Inactive
@carlosgjs carlosgjs merged commit 2c22fef into master Sep 21, 2023
23 checks passed
@carlosgjs carlosgjs deleted the carlosg/memperf branch September 21, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants