-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marine test again #315
Draft
mdenolle
wants to merge
15
commits into
main
Choose a base branch
from
marine_test_again
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Marine test again #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mdenolle
commented
Jul 5, 2024
- smooth_N was used for spectral smoothing, it should be smoothspec_N
- DC component should not be zero for autocorrelations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
=======================================
Coverage 83.52% 83.52%
=======================================
Files 9 9
Lines 1973 1973
Branches 330 332 +2
=======================================
Hits 1648 1648
Misses 207 207
Partials 118 118 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yiyu Ni <niyiyu@uw.edu>
Signed-off-by: Yiyu Ni <niyiyu@uw.edu>
Signed-off-by: Yiyu Ni <niyiyu@uw.edu>
Signed-off-by: Yiyu Ni <niyiyu@uw.edu>
Signed-off-by: Yiyu Ni <niyiyu@uw.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.