Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mechanism via github releases #271

Closed
ZyanKLee opened this issue May 20, 2022 · 4 comments · Fixed by #299
Closed

Update mechanism via github releases #271

ZyanKLee opened this issue May 20, 2022 · 4 comments · Fixed by #299
Labels
bug Something isn't working go Pull requests that update Go code good first issue Good for newcomers

Comments

@ZyanKLee
Copy link
Contributor

ZyanKLee commented May 20, 2022

Current state: Makefile currently sets noisetorch.epicgamer.org as update url.

Target state:

  • binaries published to GitHub releases are being used for updates.
  • make sure we provide a toggle switch of some kind to disable the update notification 🔗

Depends on #272

@ZyanKLee ZyanKLee added bug Something isn't working good first issue Good for newcomers labels May 20, 2022
@ZyanKLee ZyanKLee added this to To do in rising from the ashes via automation May 20, 2022
@ZyanKLee ZyanKLee added the help wanted Extra attention is needed label May 21, 2022
@ZyanKLee
Copy link
Contributor Author

When PR #272 is being merged, this issue has to be tackled next to get the update mechanism working again. Is there anybody that feels compelled to do this?

@principis
Copy link

For the person who will be working on this, make sure that the update mechanism can be disabled easily. This makes it much easier for package maintainers.

@ZyanKLee
Copy link
Contributor Author

ZyanKLee commented May 25, 2022

hey @principis, that is a great idea.

Currently it is relatively easy to disable the mechanism by removing the UPDATE_URL in line 1 of the Makefile. Doing that disables the update function in newly built packages. Would that be sufficient for what you need?

It currently is empty:

UPDATE_URL=

So when you now build a binary you will not see the warning, for example.

@principis
Copy link

@ZyanKLee that's what I'm currently doing, and it's indeed sufficient! 🙂

In practice I skip the make file and only set the needed variables, but it's effectively the same: https://pagure.io/NoiseTorch/blob/rawhide/f/noisetorch.spec#_37

@ZyanKLee ZyanKLee added go Pull requests that update Go code and removed help wanted Extra attention is needed labels May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code good first issue Good for newcomers
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants