Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removal of vendor folder #290

Open
ZyanKLee opened this issue May 24, 2022 · 7 comments
Open

removal of vendor folder #290

ZyanKLee opened this issue May 24, 2022 · 7 comments
Labels
refactoring Rewriting or improving existing behaviour

Comments

@ZyanKLee
Copy link
Contributor

ZyanKLee commented May 24, 2022

Todo:

  • removal of the folder itself
  • make sure building via make dev and make release still works
@ZyanKLee ZyanKLee added the refactoring Rewriting or improving existing behaviour label May 24, 2022
@ZyanKLee
Copy link
Contributor Author

ZyanKLee commented May 24, 2022

possible candidate: PR #269 after rebase on/merge from master and renaming

@quick0831
Copy link

I think that #297 is simple enough, however I guess something like adding vendor/ into .gitignore needs to be considered.

@quick0831
Copy link

Just for reference, #257 is closed, but I can't see a discussion in the PR, I guess we need more consideration on the disadvantage of deleting vendor/ folder.

(Just to mention that I didn't learn Go before, I might try to learn it.)

@ZyanKLee
Copy link
Contributor Author

we're having a discussion in #284

@quick0831
Copy link

we're having a discussion in #284

I see, thanks!

@TheDukeofErl
Copy link
Collaborator

I think that by inaction and not removing the vendor folder we've inadvertently made the decision to leave the vendor folder committed. Is this something that will remain the status quo or is there a reason for us to change this at this point?

@AXDOOMER
Copy link
Collaborator

I will be removing it after Hacktoberfest. I hate it because Dependabot doesn't update the dependencies in this folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Rewriting or improving existing behaviour
Projects
None yet
Development

No branches or pull requests

4 participants