-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes #269
Small fixes #269
Conversation
Please do not include other PRs with your small fixes. |
At some point a discussion needs to be had in greater depth over the removal of the vendor folder: #257 initially set out to do the same thing. |
Sure, but this is not "small fixes": |
Remove vendor folder, add to .gitignore .vscode .cache noisetorch Fix build with pr #268 |
And update go dependencies |
My suggestion to go forward is to incorporate your small fix to Your suggestions to add those entries to .gitignore are a no-brainer to me - means: I would merge those separately without batting an eye. The update to Go dependencies are a bigger issue for me. I will not do this right now; mostly because we did not decide on how to handle the vendor directory going forward. We should have a discussion on that topic. But to have that I would like to wait for a) the review being done and b) for lawl's return (if that happens within a considerable amount of time). He seemed to have a firm stance in those regards and I don't want to just brush that aside. |
I think deleting the vendor folder is a good idea (all malicious code could be stored there). As for updating dependencies, I think it's also a good idea (there's only nucular, go-glfw, gioui) for bug fixes |
While I agree that deleting the vendor folder is a good idea (hell i made the pr) it's good practice to keep pr's focused on a single issue to make merging things more straight forward. |
This have pr #268 and small fixes