Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add flawfinder action #259

Merged
merged 2 commits into from
May 21, 2022

Conversation

ZyanKLee
Copy link
Contributor

Same as with the other PR from earlier: take your time, this won't run away.

....

Here is another idea for regularly scanning the C code for probable issues: flawfinder

[...] flawfinder, a simple program that examines C/C++ source code and reports possible security weaknesses (“flaws”) sorted by risk level. It’s very useful for quickly finding and removing at least some potential security problems before a program is widely released to the public.

Scanning results with be shown in the pullrequest checks section:

grafik

as well as the security tab of the project:

grafik

So they will provide a good overview on possible improvements.

Though not all the findings have to be valid issues. Some may be conscious decisions - for example those complaints, that something can be accesses from outside of the C code (I guess at least some of that is needed to access those with the Go part of NoiseTorch?)

ZyanKLee and others added 2 commits May 19, 2022 21:54
this action scans C code for issues and reports them to the github security tab and pullrequest build status
@ZyanKLee ZyanKLee merged commit 2d96609 into noisetorch:master May 21, 2022
@ZyanKLee ZyanKLee added this to the v0.12.0 milestone May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant