fix: Make input selection aware of if "Show Monitor Sources" is checked #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, having no mic connected and display monitor sources is unchecked, clicking filter microphone results in the load button being displayed, as the monitor source will be checked by default as the first active device.
TheDukeofErl
changed the title
ZyanKLee
reviewed
May 25, 2022
|
works as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of a small corner case fix for a problem I noticed while working on a different ui problem. When Display Monitor Sources is unchecked and no mic is plugged in, if Filter Microphone is checked, Load NoiseTorch will be available with the monitor source as the "checked" element, even though it is hidden. This small modification to the check in inputSelection() fixes this bug.
Also removes a set of unnecessary parenthesis in an if.