fix: When filter is selected but no device is selected show unconfigured #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
works as expected |
TheDukeofErl
deleted the
bugfix/show-unconfigured-when-filter-but-no-selection
branch
TheDukeofErl
restored the
bugfix/show-unconfigured-when-filter-but-no-selection
branch
TheDukeofErl
deleted the
bugfix/show-unconfigured-when-filter-but-no-selection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #286. When filtering is selected but a device to filter isn't, show unconfigured rather than inactive. I more or less borrowed the logic for determining if the Load button should or shouldn't be shown, made it into a helper function, then made it be used in both cases.
I was somewhat on the fence about this but have come around to liking it.