Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Modifications #309

Merged
merged 4 commits into from
Jun 1, 2022
Merged

Readme Modifications #309

merged 4 commits into from
Jun 1, 2022

Conversation

RiemaruKarurosu
Copy link
Contributor

@RiemaruKarurosu RiemaruKarurosu commented Jun 1, 2022

Sorry for the delay:

  • Center shields
  • Release has a different package name (includes version)

I'm not sure how to get the package release name because in the noisetorch README says

`Unpack the tgz file, into your home directory.

tar -C $HOME -xzf NoiseTorch_x64.tgz`

And the command finally is tar -C $HOME -xzf NoiseTorch_x64_v0.12.0.tgz, it really doesn't matter I think, so I'm not sure if it should change, but i add it.

- Center shields
- Release has a different package name (includes version)
README.md Outdated Show resolved Hide resolved
Co-authored-by: Kevin <TheDukeofErl@users.noreply.github.com>
Copy link
Contributor

@ZyanKLee ZyanKLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries about any delay. there are more important things than badge alignments.
Nevertheless, this looks great.

There are only some small things I found.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
RiemaruKarurosu and others added 2 commits June 1, 2022 16:50
Co-authored-by: ZyanKLee <ZyanKLee@users.noreply.github.com>
Co-authored-by: ZyanKLee <ZyanKLee@users.noreply.github.com>
@ZyanKLee ZyanKLee merged commit 698d568 into noisetorch:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants