Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Switch to org pulseaudio #320

Merged
merged 5 commits into from Jun 6, 2022

Conversation

TheDukeofErl
Copy link
Collaborator

Removes lawl/pulseaudio and adds noisetorch/pulseaudio. Completes #298. I did not commit the vendor folder for noisetorch/pulseaudio due to #297, however, we should merge that first if we want to remove the vendor folder for consistency's sake.

If that isn't done before we want to merge this I'd say it's best to add the noisetorch vendor folder to this PR to avoid ending up with the large amount of untracked files lying around after a go mod vendor.

@TheDukeofErl
Copy link
Collaborator Author

Due to the lack of a go mod vendor, this build will fail due to the vendor folder for noisetorch/pulseaudio not being committed. I'm just going to go ahead and add that to this PR. If we want to remove it after the fact in #297 we can.

@ZyanKLee ZyanKLee merged commit 9d74c44 into noisetorch:master Jun 6, 2022
@ZyanKLee
Copy link
Contributor

ZyanKLee commented Jun 6, 2022

Oh damn, I'm just too tired and forgot about #297 needing to be merged first. Sorry, but I need to revert this.

@TheDukeofErl
Copy link
Collaborator Author

Oh damn, I'm just too tired and forgot about #297 needing to be merged first. Sorry, but I need to revert this.

Oh, this didn't need #297 merged, just that that PR would have to be updated.

@TheDukeofErl TheDukeofErl deleted the switch-to-org-pulseaudio branch August 10, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants