fix(update): strip 'v' from version string #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for comparing the version strings with semver (and only there), we need to strip the 'v' prefix from the version strings.
AXDOOMER
approved these changes
Jun 17, 2022
AXDOOMER
requested changes
Jun 17, 2022
There was a problem hiding this comment.
You'll get an index out of range in update.go because the code doesn't check for errors before making the semver. You can test this by disabling your internet connection.
Also, I'd prefer strings.TrimLeft(verstr, "v"). This is better than blindly stripping the first char.
TrimLeft is more reliable as it won't crash if the string is empty
AXDOOMER
approved these changes
Jun 17, 2022
TheDukeofErl
approved these changes
Jun 17, 2022
|
I'll have a last check if it actually really works now, then I will merge it and tag 0.12.2 |
|
everything works now ... yeah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for comparing the version strings with semver (and only there), we need to strip the 'v' prefix from the version strings.