Add missing defaults for the coolant based advance curve

speeduino · Jun 6, 2019 · 1943d0f · 1943d0f
1 parent 28fae10
commit 1943d0f
Show file tree

Hide file tree

Showing 4 changed files with 49 additions and 3 deletions.
diff --git a/reference/Base Tunes/NA6 PNP base tune.msq b/reference/Base Tunes/NA6 PNP base tune.msq
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="ISO-8859-1"?>
 <msq xmlns="http://www.msefi.com/:msq">
-<bibliography author="TunerStudio MS(Beta) 3.0.60.55 - EFI Analytics, Inc." tuneComment="" writeDate="Thu Jun 06 20:06:42 AEST 2019"/>
+<bibliography author="TunerStudio MS(Beta) 3.0.60.55 - EFI Analytics, Inc." tuneComment="" writeDate="Thu Jun 06 23:25:47 AEST 2019"/>
 <versionInfo fileFormat="5.0" firmwareInfo="Speeduino+2019.03" nPages="11" signature="speeduino 201905"/>
 <page>
 <pcVariable name="tsCanId">"CAN ID 0"</pcVariable>
@@ -341,6 +341,22 @@
 <constant digits="0" name="ADCFILTER_BAT" units="%">128.0</constant>
 <constant digits="0" name="ADCFILTER_MAP" units="%">20.0</constant>
 <constant digits="0" name="ADCFILTER_BARO" units="%">64.0</constant>
+<constant cols="1" digits="0" name="cltAdvBins" rows="6" units="C">
+         0.0 
+         20.0 
+         50.0 
+         70.0 
+         85.0 
+         100.0 
+      </constant>
+<constant cols="1" digits="1" name="cltAdvValues" rows="6" units="deg">
+         0.0 
+         0.0 
+         0.0 
+         0.0 
+         0.0 
+         0.0 
+      </constant>
 <constant cols="1" digits="0" name="maeBins" rows="4" units="kpa/s">
          10.0 
          260.0 

diff --git a/reference/Base Tunes/Speeduino base tune.msq b/reference/Base Tunes/Speeduino base tune.msq
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="ISO-8859-1"?>
 <msq xmlns="http://www.msefi.com/:msq">
-<bibliography author="TunerStudio MS(Beta) 3.0.60.55 - EFI Analytics, Inc." tuneComment="" writeDate="Thu Jun 06 19:59:24 AEST 2019"/>
+<bibliography author="TunerStudio MS(Beta) 3.0.60.55 - EFI Analytics, Inc." tuneComment="" writeDate="Thu Jun 06 23:28:41 AEST 2019"/>
 <versionInfo fileFormat="5.0" firmwareInfo="Speeduino+2019.03" nPages="11" signature="speeduino 201905"/>
 <page>
 <pcVariable name="tsCanId">"CAN ID 0"</pcVariable>
@@ -341,6 +341,22 @@
 <constant digits="0" name="ADCFILTER_BAT" units="%">128.0</constant>
 <constant digits="0" name="ADCFILTER_MAP" units="%">20.0</constant>
 <constant digits="0" name="ADCFILTER_BARO" units="%">64.0</constant>
+<constant cols="1" digits="0" name="cltAdvBins" rows="6" units="C">
+         0.0 
+         20.0 
+         40.0 
+         60.0 
+         80.0 
+         100.0 
+      </constant>
+<constant cols="1" digits="1" name="cltAdvValues" rows="6" units="deg">
+         0.0 
+         0.0 
+         0.0 
+         0.0 
+         0.0 
+         0.0 
+      </constant>
 <constant cols="1" digits="0" name="maeBins" rows="4" units="kpa/s">
          80.0 
          220.0 

diff --git a/reference/speeduino.ini b/reference/speeduino.ini
@@ -1392,7 +1392,7 @@ menuDialog = main
 
 	enable_secondarySerial = "This Enables the secondary serial port . Secondary serial is serial3 on mega2560 processor, and Serial2 on STM32 and Teensy processor "
 
-    cltAdvValues = "This curve can be used to advance ignition timing when engine is warming up. This can also be used to warm up the catalytic converters in cold start by retarding timing. Or even as safety feature to retard timign when engine is too hot to prevent knock."
+    cltAdvValues = "This curve can be used to advance ignition timing when engine is warming up. This can also be used to warm up the catalytic converters in cold start by retarding timing. Or even as safety feature to retard timing when engine is too hot to prevent knock."
 
 	;speeduino_tsCanId = "This is the TsCanId that the Speeduino ECU will respond to. This should match the main controller CAN ID in project properties if it is connected directy to TunerStudio, Otherwise the device ID if connected via CAN passthrough"
 	true_address = "This is the 11bit Can address of the Speeduino ECU "

diff --git a/speeduino/updates.ino b/speeduino/updates.ino
@@ -196,6 +196,20 @@ void doUpdates()
     configPage2.aseBins[2] = 60;
     configPage2.aseBins[3] = 80;
 
+    //Coolant based ignition advance was added also. Set sane values
+    configPage4.cltAdvBins[0] = 0;
+    configPage4.cltAdvBins[1] = 30;
+    configPage4.cltAdvBins[2] = 60;
+    configPage4.cltAdvBins[3] = 70;
+    configPage4.cltAdvBins[4] = 85;
+    configPage4.cltAdvBins[5] = 100;
+    configPage4.cltAdvValues[0] = 0;
+    configPage4.cltAdvValues[1] = 0;
+    configPage4.cltAdvValues[2] = 0;
+    configPage4.cltAdvValues[3] = 0;
+    configPage4.cltAdvValues[4] = 0;
+    configPage4.cltAdvValues[5] = 0;
+
 
     //March 19 added a tacho pulse duration that could default to stupidly high values. Check if this is the case and fix it if found. 6ms is tha maximum allowed value
     if(configPage2.tachoDuration > 6) { configPage2.tachoDuration = 3; }